Review main Merged

76709[TASK] Remove null coalesce operator on always true value in ContentObjectRenderer

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 11/19/22, 23:18

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Nikita Hovratov uploaded patch set 1 11/19/22, 17:10

  2. core-ci voted on patch set 1 V +1 11/19/22, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33966

  3. Oliver Klee voted on patch set 1 CR +1 11/19/22, 17:31

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 11/19/22, 17:42

  5. Stefan Bürk commented on patch set 1 11/19/22, 20:24

    ContentObjectRenderer.php:1187

    Should we not add a check here that `$conf[$functionProperties` is actually an array ?
  6. Nikita Hovratov commented on patch set 1 11/19/22, 20:40

    ContentObjectRenderer.php:1187 Reply

    I guess any entry with <functionName>. is an array per definition. I don't know if there are exceptions. Of course more strictness is always better, but maybe in another patch? Just wanted to get rid of a small code smell PhpStorm found.
  7. Stefan Bürk commented on patch set 1 11/19/22, 23:18

    ContentObjectRenderer.php:1187 Reply

    Ack
  8. Stefan Bürk voted on patch set 1 V +2 CR +2 11/19/22, 23:18

  9. Stefan Bürk merged patch set 2 11/19/22, 23:18