76709[TASK] Remove null coalesce operator on always true value in ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 89
-
Nikita Hovratov uploaded patch set 1 11/19/22, 17:10
-
core-ci voted on patch set 1 V +1 11/19/22, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33966
-
Oliver Klee voted on patch set 1 CR +1 11/19/22, 17:31
-
Christian Kuhn voted on patch set 1 V +1 CR +1 11/19/22, 17:42
-
Stefan Bürk commented on patch set 1 11/19/22, 20:24
-
Nikita Hovratov commented on patch set 1 11/19/22, 20:40
ContentObjectRenderer.php:1187ReplyI guess any entry with <functionName>. is an array per definition. I don't know if there are exceptions. Of course more strictness is always better, but maybe in another patch? Just wanted to get rid of a small code smell PhpStorm found. -
Stefan Bürk commented on patch set 1 11/19/22, 23:18
ContentObjectRenderer.php:1187ReplyAck -
Stefan Bürk voted on patch set 1 V +2 CR +2 11/19/22, 23:18
-
Stefan Bürk merged patch set 2 11/19/22, 23:18
ContentObjectRenderer.php:1187