76710[TASK] Replace prophecy in EXT:core/Tests/Unit/Page/*
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1012
-
Torben Hansen uploaded patch set 1 11/19/22, 17:53
-
core-ci voted on patch set 1 V +1 11/19/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33967
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 11/19/22, 20:06
-
Stefan Bürk commented on patch set 1 CR -1 11/19/22, 20:16
on itImportMapTest.php:36Thanks for moving them up.ImportMapTest.php:238This changes now from a concrete `is string` check to a `mixed` check. This should be `self::isType('string')` instead.PageRendererFactoryTrait.php:75Mocking this is superflous (and was before). Core ResponseFactory can be used directly.PageRendererFactoryTrait.php:76Mocking this is superflous (and was before). Core StreamFactory can be used directly.PageRendererTest.php:37Should be two times `self::isType('string')` to have the same test setup as before. Otherwise it would be a change from "only strings allowed" to "give me what you want". -
Stefan Bürk uploaded patch set 2 11/19/22, 20:21
-
Stefan Bürk commented on patch set 2 11/19/22, 20:24
ImportMapTest.php:36ReplyDoneImportMapTest.php:238ReplyDonePageRendererFactoryTrait.php:75ReplyDonePageRendererFactoryTrait.php:76ReplyDonePageRendererTest.php:37ReplyDone -
Nikita Hovratov commented on patch set 2 CR +1 11/19/22, 20:26
Reply
thanks! -
core-ci voted on patch set 2 V +1 11/19/22, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33973
-
Nikita Hovratov voted on patch set 2 V +1 11/19/22, 20:29
-
Stefan Bürk voted on patch set 2 V +2 CR +2 11/19/22, 20:29
-
Stefan Bürk merged patch set 3 11/19/22, 20:29
-
Torben Hansen commented on patch set 3 11/20/22, 05:42
PageRendererTest.php:37ReplyThanks for taking care. I did not know `self::isType()` until now.