Review main Merged

76710[TASK] Replace prophecy in EXT:core/Tests/Unit/Page/*

Torben Hansen CR +2 V +2 Normal +54 −62 updated 11/20/22, 05:42

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1012

  1. Torben Hansen uploaded patch set 1 11/19/22, 17:53

  2. core-ci voted on patch set 1 V +1 11/19/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33967

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/19/22, 20:06

  4. Stefan Bürk commented on patch set 1 CR -1 11/19/22, 20:16

    on it

    ImportMapTest.php:36

    Thanks for moving them up.

    ImportMapTest.php:238

    This changes now from a concrete `is string` check to a `mixed` check. This should be `self::isType('string')` instead.

    PageRendererFactoryTrait.php:75

    Mocking this is superflous (and was before). Core ResponseFactory can be used directly.

    PageRendererFactoryTrait.php:76

    Mocking this is superflous (and was before). Core StreamFactory can be used directly.

    PageRendererTest.php:37

    Should be two times `self::isType('string')` to have the same test setup as before. Otherwise it would be a change from "only strings allowed" to "give me what you want".
  5. Stefan Bürk uploaded patch set 2 11/19/22, 20:21

  6. Stefan Bürk commented on patch set 2 11/19/22, 20:24

    ImportMapTest.php:36 Reply

    Done

    ImportMapTest.php:238 Reply

    Done

    PageRendererFactoryTrait.php:75 Reply

    Done

    PageRendererFactoryTrait.php:76 Reply

    Done

    PageRendererTest.php:37 Reply

    Done
  7. Nikita Hovratov commented on patch set 2 CR +1 11/19/22, 20:26

    Reply

    thanks!
  8. core-ci voted on patch set 2 V +1 11/19/22, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33973

  9. Nikita Hovratov voted on patch set 2 V +1 11/19/22, 20:29

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 11/19/22, 20:29

  11. Stefan Bürk merged patch set 3 11/19/22, 20:29

  12. Torben Hansen commented on patch set 3 11/20/22, 05:42

    PageRendererTest.php:37 Reply

    Thanks for taking care. I did not know `self::isType()` until now.