76713[TASK] Remove prophecy in EXT:core SiteTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 811
-
Torben Hansen uploaded patch set 1 11/19/22, 18:47
-
core-ci voted on patch set 1 V +1 11/19/22, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33970
-
Oliver Klee commented on patch set 1 11/19/22, 19:13
-
Stefan Bürk commented on patch set 1 CR -1 11/19/22, 19:58
on itSiteTest.php:217ReplyCorrect. And I'm not fully comply with the commit commit message. Granted, against the PageErrorHandlerInterface is superflous. But given the name "ReturnsConfiguredErrorHandler" it should changed to assert the concrete "configured" error handler instance (or which may be expected). Otherwhise the whole test would not make any sense. -
Stefan Bürk uploaded patch set 2 11/19/22, 20:03
-
Stefan Bürk updated the commit message in patch set 3 11/19/22, 20:07
-
core-ci voted on patch set 2 V +1 11/19/22, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33971
-
core-ci voted on patch set 3 V +1 11/19/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33972
-
Stefan Bürk commented on patch set 3 V +1 CR +1 11/19/22, 20:15
SiteTest.php:217ReplyDone -
Nikita Hovratov commented on patch set 3 V +2 CR +2 11/19/22, 20:23
SiteTest.php:217Replythanks for taking care -
Nikita Hovratov merged patch set 4 11/19/22, 20:24
SiteTest.php:217