Review main Merged

76713[TASK] Remove prophecy in EXT:core SiteTest

Torben Hansen CR +2 V +2 Easy +4 −8 updated 11/19/22, 20:24

Commit message

Besides the prophecy removal, also 3 assertions
are changed to assert concrete class instances
instead of generic interface. Thus avoid having
superflous tests and transform them into a good
test assertion.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Torben Hansen uploaded patch set 1 11/19/22, 18:47

  2. core-ci voted on patch set 1 V +1 11/19/22, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33970

  3. Oliver Klee commented on patch set 1 11/19/22, 19:13

    SiteTest.php:217

    If I read this change correctly, now the test does not have any assertions left and does not check what it claims ("…ReturnsConfiguredErrorHandler"). Am I missing something here?
  4. Stefan Bürk commented on patch set 1 CR -1 11/19/22, 19:58

    on it

    SiteTest.php:217 Reply

    Correct. And I'm not fully comply with the commit commit message. Granted, against the PageErrorHandlerInterface is superflous. But given the name "ReturnsConfiguredErrorHandler" it should changed to assert the concrete "configured" error handler instance (or which may be expected). Otherwhise the whole test would not make any sense.
  5. Stefan Bürk uploaded patch set 2 11/19/22, 20:03

  6. Stefan Bürk updated the commit message in patch set 3 11/19/22, 20:07

  7. core-ci voted on patch set 2 V +1 11/19/22, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33971

  8. core-ci voted on patch set 3 V +1 11/19/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33972

  9. Stefan Bürk commented on patch set 3 V +1 CR +1 11/19/22, 20:15

    SiteTest.php:217 Reply

    Done
  10. Nikita Hovratov commented on patch set 3 V +2 CR +2 11/19/22, 20:23

    SiteTest.php:217 Reply

    thanks for taking care
  11. Nikita Hovratov merged patch set 4 11/19/22, 20:24