76732[TASK] Consolidate DocType handling as Enum
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+0 −4
- typo3/sysext/core/Classes/Page/PageRenderer.php2+62 −5
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+10 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php3+10 −1
- typo3/sysext/core/Classes/Type/DocType.phpnew+148 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Deprecation-99416-VariousDoctypeRelatedPropertiesAndMethods.rstnew+55 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+6 −9
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+6 −3
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+4 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+11 −25
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+21 −79
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+8 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+8 −2
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+42 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+10 −0
Review log 2031
Show 36 earlier messages
-
Benni Mack uploaded patch set 1 11/19/22, 22:09
-
core-ci voted on patch set 1 V -1 11/19/22, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33974
-
Benni Mack uploaded patch set 2
V -112/22/22, 12:51 -
core-ci voted on patch set 2 V -1 12/22/22, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35304
-
Benni Mack uploaded patch set 3
V -112/22/22, 20:13 -
core-ci voted on patch set 3 V -1 12/22/22, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35308
-
Benni Mack uploaded patch set 4
V -112/22/22, 20:34 -
core-ci voted on patch set 4 V -1 12/22/22, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35309
-
Benni Mack uploaded patch set 5
V -112/22/22, 20:50 -
core-ci voted on patch set 5 V -1 12/22/22, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35310
-
Benni Mack uploaded patch set 6
V -112/22/22, 21:07 -
core-ci voted on patch set 6 V -1 12/22/22, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35312
-
Benni Mack uploaded patch set 7
V -112/22/22, 21:24 -
core-ci voted on patch set 7 V +1 12/22/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35313
-
Benni Mack uploaded patch set 8
V +112/22/22, 22:12 -
core-ci voted on patch set 8 V -1 12/22/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35314
-
Benni Mack uploaded patch set 9
V -112/22/22, 23:00 -
core-ci voted on patch set 9 V +1 12/22/22, 23:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35316
-
Benni Mack uploaded patch set 10
V +112/22/22, 23:58 -
core-ci voted on patch set 10 V +1 12/23/22, 00:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35318
-
Susi Moog commented on patch set 10 CR +1 12/23/22, 07:01
-
Oliver Klee commented on patch set 10 12/23/22, 08:33
YouTubeRenderer.php:235From an architectural point of view, I'd see this method in the new DocType class. (Then we'd also avoid the duplication with the VimeoRendererClass.) -
Benni Mack uploaded patch set 11
CR +1V +112/23/22, 09:32 -
Benni Mack commented on patch set 10 12/23/22, 09:32
PageRenderer.php:819ReplyDoneYouTubeRenderer.php:235Replydone, although I kept the wrapper method in there for mocking purposes in tests. -
Chris Müller commented on patch set 10 12/23/22, 09:34
Perhaps name the DocType "DocumentType" to avoid confusion with the DokType of the pages table. -
core-ci voted on patch set 11 V +1 12/23/22, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35325
-
Benni Mack commented on patch set 11 12/23/22, 09:44
Reply
Thought about this as well, also discussed this with Susi. DOCTYPE is actually the main reasoning for defining the document. see https://developer.mozilla.org/en-US/docs/Glossary/Doctype Other ideas next to "DocumentType" was also "PageRenderingType" or "RenderingType" which both fit, but then this is all much more related to other places (e.g. "DocType::JSON" or "DocType::text" or something similar), but that would then happen at a later stage. -
Oliver Klee commented on patch set 11 12/23/22, 11:02
YouTubeRenderer.php:235ReplyAh, okay, I see. Thanks. -
Susi Moog voted on patch set 11 V +1 CR +1 12/23/22, 14:37
-
Georg Ringer voted on patch set 11 V +2 CR +2 12/23/22, 14:57
-
Georg Ringer merged patch set 12 12/23/22, 14:57
PageRenderer.php:819