Review main Merged

76736[TASK] Remove prophecy in EXT:core BootstrapRendererTest

Torben Hansen CR +2 V +2 Easy +5 −9 updated 11/20/22, 14:15

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Torben Hansen uploaded patch set 1 11/20/22, 12:34

  2. Oliver Klee commented on patch set 1 CR -1 11/20/22, 12:48

    BootstrapRendererTest.php:34

    Prophecy -> Mock (for both mocks)
  3. Torben Hansen uploaded patch set 2 CR -1 11/20/22, 12:53

  4. Torben Hansen commented on patch set 2 11/20/22, 12:54

    BootstrapRendererTest.php:34 Reply

    Thanks, done.
  5. Oliver Klee voted on patch set 2 CR +1 11/20/22, 13:02

  6. core-ci voted on patch set 1 V +1 11/20/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33993

  7. core-ci voted on patch set 2 V +1 11/20/22, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33998

  8. Oliver Klee voted on patch set 2 V +1 11/20/22, 13:25

  9. Christian Kuhn rebased onto patch set 3 CR +1 V +1 11/20/22, 14:01

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/22, 14:02

  11. core-ci voted on patch set 3 V +1 11/20/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34003

  12. Stefan Bürk voted on patch set 3 V +2 CR +2 11/20/22, 14:15

  13. Stefan Bürk merged patch set 4 11/20/22, 14:15