76748[TASK] Replace prophecy in EXT:core TypoScriptParserTest
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Nikita Hovratov uploaded patch set 1 11/20/22, 19:00
-
core-ci voted on patch set 1 V +1 11/20/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34015
-
Oliver Klee voted on patch set 1 V +1 11/20/22, 20:10
-
Oliver Klee commented on patch set 1 11/20/22, 20:13
TypoScriptParserTest.php:456While we're touching these lines anyway, I propose to rename $p to something more communicative. -
Nikita Hovratov commented on patch set 1 11/20/22, 21:52
TypoScriptParserTest.php:360ReplyThis test file will be moved to UnitDeprecated soon. So lets not bother to optimize it further.TypoScriptParserTest.php:456ReplyHey, I thought the same. BUT: This test file will be moved to UnitDeprecated soon. So lets not bother to optimize it further. -
Oliver Klee commented on patch set 1 CR +1 11/21/22, 08:10
TypoScriptParserTest.php:360ReplyAckTypoScriptParserTest.php:456ReplyAck -
Georg Ringer voted on patch set 1 V +2 CR +2 11/21/22, 12:23
-
Georg Ringer merged patch set 2 11/21/22, 12:23
TypoScriptParserTest.php:360