76749[TASK] Replace prophecy in EXT:core GeneralUtilityTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1517
-
Nikita Hovratov uploaded patch set 1 11/20/22, 20:03
-
core-ci voted on patch set 1 V +1 11/20/22, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34016
-
Oliver Klee commented on patch set 1 11/20/22, 20:15
-
Oliver Klee voted on patch set 1 V +1 11/20/22, 20:16
-
Nikita Hovratov commented on patch set 1 11/20/22, 21:57
GeneralUtilityTest.php:3650ReplyWe already have: `protected bool $resetSingletonInstances = true;` -
Oliver Klee commented on patch set 1 11/21/22, 08:09
GeneralUtilityTest.php:3650ReplyAck -
Oliver Klee voted on patch set 1 CR +1 11/21/22, 08:09
-
Stefan Bürk commented on patch set 1 11/22/22, 23:31
GeneralUtilityTest.php:3647we should add a expect to match the `shouldBeCalled()` of the prior prophecy variant. ``` ->expects(self::atLeastOnce()) ``` -
Oliver Klee voted on patch set 1 CR 0 11/23/22, 07:55
-
Nikita Hovratov uploaded patch set 2
V +111/23/22, 08:40 -
Nikita Hovratov commented on patch set 2 11/23/22, 08:40
GeneralUtilityTest.php:3647ReplyDone -
Stefan Bürk commented on patch set 2 V +1 CR +1 11/23/22, 08:46
GeneralUtilityTest.php:3647ReplyI was blind last night .. there was a expects() oO :( :( my bad -
core-ci voted on patch set 2 V +1 11/23/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34102
-
Nikita Hovratov commented on patch set 2 11/23/22, 09:59
GeneralUtilityTest.php:3647ReplyAh, I thought you meant to change once to atLeastOnce. No, problem! -
Georg Ringer voted on patch set 2 V +1 CR +1 11/23/22, 10:09
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 11/23/22, 13:03
-
Nikita Hovratov merged patch set 3 11/23/22, 13:03
GeneralUtilityTest.php:3650