Review main Merged

76749[TASK] Replace prophecy in EXT:core GeneralUtilityTest

Nikita Hovratov CR +2 V +2 Easy +7 −9 updated 11/23/22, 13:03

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1517

  1. Nikita Hovratov uploaded patch set 1 11/20/22, 20:03

  2. core-ci voted on patch set 1 V +1 11/20/22, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34016

  3. Oliver Klee commented on patch set 1 11/20/22, 20:15

    GeneralUtilityTest.php:3650

    We also should call GU::purgeInstances in tearDown.
  4. Oliver Klee voted on patch set 1 V +1 11/20/22, 20:16

  5. Nikita Hovratov commented on patch set 1 11/20/22, 21:57

    GeneralUtilityTest.php:3650 Reply

    We already have: `protected bool $resetSingletonInstances = true;`
  6. Oliver Klee commented on patch set 1 11/21/22, 08:09

    GeneralUtilityTest.php:3650 Reply

    Ack
  7. Oliver Klee voted on patch set 1 CR +1 11/21/22, 08:09

  8. Stefan Bürk commented on patch set 1 11/22/22, 23:31

    GeneralUtilityTest.php:3647

    we should add a expect to match the `shouldBeCalled()` of the prior prophecy variant. ``` ->expects(self::atLeastOnce()) ```
  9. Oliver Klee voted on patch set 1 CR 0 11/23/22, 07:55

  10. Nikita Hovratov uploaded patch set 2 V +1 11/23/22, 08:40

  11. Nikita Hovratov commented on patch set 2 11/23/22, 08:40

    GeneralUtilityTest.php:3647 Reply

    Done
  12. Stefan Bürk commented on patch set 2 V +1 CR +1 11/23/22, 08:46

    GeneralUtilityTest.php:3647 Reply

    I was blind last night .. there was a expects() oO :( :( my bad
  13. core-ci voted on patch set 2 V +1 11/23/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34102

  14. Nikita Hovratov commented on patch set 2 11/23/22, 09:59

    GeneralUtilityTest.php:3647 Reply

    Ah, I thought you meant to change once to atLeastOnce. No, problem!
  15. Georg Ringer voted on patch set 2 V +1 CR +1 11/23/22, 10:09

  16. Nikita Hovratov voted on patch set 2 V +2 CR +2 11/23/22, 13:03

  17. Nikita Hovratov merged patch set 3 11/23/22, 13:03