Review main Merged

76752[TASK] Convert ExtendedFileUtilityTest to functional

Nikita Hovratov CR +2 V +2 Normal +93 −130 updated 11/23/22, 15:31

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 11/20/22, 21:49

  2. core-ci voted on patch set 1 V -1 11/20/22, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34019

  3. Nikita Hovratov uploaded patch set 2 V -1 11/20/22, 22:00

  4. core-ci voted on patch set 2 V +1 11/20/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34020

  5. Oliver Klee voted on patch set 2 V +1 11/20/22, 23:30

  6. Stefan Bürk commented on patch set 2 11/22/22, 23:36

    sys_file.csv:3

    I think we should escape string values with double quotes. Same identifer_hash, folder_hash, extension, name and sha1

    sys_refindex.csv:3

    Values for text/string fields should be enquoted with double quotes in csv fixture files. We do this in all (at least in most of them).
  7. Nikita Hovratov uploaded patch set 3 V +1 11/23/22, 08:36

  8. Nikita Hovratov commented on patch set 3 11/23/22, 08:37

    sys_file.csv:3 Reply

    Done

    sys_refindex.csv:3 Reply

    Done
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 11/23/22, 08:47

  10. core-ci voted on patch set 3 V +1 11/23/22, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34101

  11. Benni Mack voted on patch set 3 CR +1 11/23/22, 13:51

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 11/23/22, 15:30

  13. Christian Kuhn merged patch set 4 11/23/22, 15:31