Review 11.5 Merged

76756[BUGFIX] Prevent PHP 8.1 runtime deprecation notice in IconRegistry

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 11/21/22, 13:19

Commit message

IconRegistry->detectIconProvider() may receive a null value for
the $iconReference parameter. E.g. in
IconRegistry->registerModuleIcons(). Therefore, a cast to string is
needed for strtolower.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Nikita Hovratov uploaded patch set 1 11/21/22, 11:15

  2. core-ci voted on patch set 1 V +1 11/21/22, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34033

  3. Oliver Klee voted on patch set 1 V +1 CR +1 11/21/22, 11:28

  4. Oliver Klee commented on patch set 1 V 0 CR -1 11/21/22, 11:29

    This also affects main, and we should fix it there first.
  5. Nikita Hovratov updated the commit message in patch set 2 CR -1 V +1 11/21/22, 11:40

  6. Nikita Hovratov commented on patch set 2 11/21/22, 11:41

    Reply

    Yes, you're right. Eventhough the causing code part in core doesn't exist anymore, it should be fixed for custom code.
  7. Oliver Klee voted on patch set 2 CR +1 11/21/22, 11:41

  8. Nikita Hovratov commented on patch set 2 11/21/22, 11:41

    Reply

    Done
  9. Oliver Klee commented on patch set 2 11/21/22, 11:42

    Reply

    Done
  10. core-ci voted on patch set 2 V +1 11/21/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34035

  11. Oliver Klee voted on patch set 2 V +1 11/21/22, 12:00

  12. Benjamin Franzke voted on patch set 2 V +1 CR +1 11/21/22, 12:51

  13. Nikita Hovratov voted on patch set 2 V +2 CR +2 11/21/22, 13:18

  14. Nikita Hovratov merged patch set 3 11/21/22, 13:19