Review main Merged

76757[BUGFIX] Prevent PHP 8.1 runtime deprecation notice in IconRegistry

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 11/21/22, 13:18

Commit message

IconRegistry->detectIconProvider() may receive a null value for
the $iconReference parameter. E.g. in
IconRegistry->registerModuleIcons(). Therefore, a cast to string is
needed for strtolower.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 11/21/22, 11:40

  2. Oliver Klee voted on patch set 1 CR +1 11/21/22, 11:41

  3. core-ci voted on patch set 1 V +1 11/21/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34034

  4. Oliver Klee voted on patch set 1 V +1 11/21/22, 12:00

  5. Benjamin Franzke commented on patch set 1 V +1 CR +1 11/21/22, 12:50

    Hm, I think this could only be triggered with v11 with the call in registerModuleIcons() (which has been removed in v12): https://github.com/TYPO3/typo3/blob/v11.5.19/typo3/sysext/core/Classes/Imaging/IconRegistry.php#L543-L546 But fine with me to fix this here, as we cannot simply introduce strict typing here.
  6. Nikita Hovratov voted on patch set 1 V +2 CR +2 11/21/22, 13:18

  7. Nikita Hovratov merged patch set 2 11/21/22, 13:18