Review main Merged

76762[BUGFIX] Avoid undefined array key in AbstractPlugin::pi_exec_query

J. Peter M. Schuler CR +2 V +2 Easy +1 −1 updated 11/22/22, 23:04

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. J. Peter M. Schuler uploaded patch set 1 11/21/22, 21:16

  2. core-ci voted on patch set 1 V +1 11/21/22, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34051

  3. Oliver Klee commented on patch set 1 11/21/22, 21:34

    AbstractPlugin.php:1014

    While we're at it, please let's add an int cast to the recursive argument to ensure its type.
  4. J. Peter M. Schuler uploaded patch set 2 V +1 11/21/22, 21:53

  5. J. Peter M. Schuler commented on patch set 2 11/21/22, 21:54

    int type cast added, as requested.

    AbstractPlugin.php:1014 Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/21/22, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34052

  7. Oliver Klee voted on patch set 2 CR +1 11/21/22, 22:08

  8. Chris Müller voted on patch set 2 CR +1 11/22/22, 05:34

  9. Georg Ringer voted on patch set 2 CR +1 11/22/22, 07:11

  10. Benni Mack voted on patch set 2 V +1 CR +1 11/22/22, 21:33

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 11/22/22, 23:04

  12. Stefan Bürk merged patch set 3 11/22/22, 23:04