Review main Merged

76766[BUGFIX] Use correct ordering of nl2br & htmlspecialchars

Georg Ringer CR +2 V +2 Easy +3 −3 updated 11/22/22, 21:35

Commit message

The ViewHelper `f:format.nl2br` must be applied after
`f:format.htmlspecialchars()`.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2024

  1. Georg Ringer uploaded patch set 1 11/22/22, 10:38

  2. Georg Ringer commented on patch set 1 11/22/22, 10:39

    This change is ready for review.
  3. Anja Leichsenring updated the commit message in patch set 2 11/22/22, 10:40

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/22/22, 10:41

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 11/22/22, 10:43

  6. core-ci voted on patch set 1 V +1 11/22/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34064

  7. core-ci voted on patch set 2 V +1 11/22/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34065

  8. Oliver Klee voted on patch set 2 CR +1 11/22/22, 10:57

  9. Markus Klein voted on patch set 2 V +1 CR +1 11/22/22, 11:01

  10. Stefan Froemken commented on patch set 2 V +1 CR +1 11/22/22, 11:20

    Works, but <source> A regular text element with header and bodytext fields </source> Will add br before the translated output. What do you think about a trim in getDescription()?
  11. Stefan Froemken commented on patch set 2 11/22/22, 11:23

    Sorry. NewContentElementController::getWizardItem(). Add trim for translation of description
  12. Georg Ringer uploaded patch set 3 CR +1 V +1 11/22/22, 11:48

  13. Oliver Klee voted on patch set 3 CR +1 11/22/22, 11:52

  14. Stefan Froemken commented on patch set 3 V +1 CR +1 11/22/22, 11:53

    Yeah. Patch 3 is nice.
  15. core-ci voted on patch set 3 V +1 11/22/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34070

  16. Anja Leichsenring updated the commit message in patch set 4 CR +1 V +1 11/22/22, 12:05

  17. Anja Leichsenring voted on patch set 4 V +1 CR +1 11/22/22, 12:06

  18. Oliver Klee voted on patch set 4 CR +1 11/22/22, 12:11

  19. core-ci voted on patch set 4 V +1 11/22/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34073

  20. Stefan Froemken voted on patch set 4 V +1 CR +1 11/22/22, 12:38

  21. Nikita Hovratov voted on patch set 4 V +2 CR +2 11/22/22, 21:16

  22. Nikita Hovratov commented on patch set 4 V -1 CR +1 11/22/22, 21:19

    conflict in backport, will fix it before merging into main.
  23. Nikita Hovratov voted on patch set 4 V +2 CR +2 11/22/22, 21:35

  24. Nikita Hovratov merged patch set 5 11/22/22, 21:35