76768[TASK] Deprecate config.baseURL
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Susi Moog +1
-
Verified V +2 Done
- Andreas Kienast +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Page/PageRenderer.php3+10 −1
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-99170-ConfigbaseURLAndBaseTagFunctionality.rstnew+81 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+0 −6
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+21 −0
Review log 1421
-
Benni Mack uploaded patch set 1 11/22/22, 21:45
-
core-ci voted on patch set 1 V -1 11/22/22, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34084
-
Benni Mack uploaded patch set 2
V -111/23/22, 09:25 -
core-ci voted on patch set 2 V +1 11/23/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34106
-
Benni Mack updated the commit message in patch set 3
V +111/23/22, 10:10 -
core-ci voted on patch set 3 V +1 11/23/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34108
-
Benni Mack updated the commit message in patch set 4
V +111/23/22, 16:49 -
core-ci voted on patch set 4 V +1 11/23/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34123
-
Benni Mack uploaded patch set 5
V +111/25/22, 21:48 -
core-ci voted on patch set 5 V +1 11/25/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34245
-
Andreas Kienast commented on patch set 5 11/26/22, 19:24
-
Benni Mack commented on patch set 5 11/27/22, 14:10
PageRenderer.php:570Replysure, but that's much more code (= and perf penalty) when using this option in v12 :) I could imagine that's a bit overkill for this deprecation. (we've been using the $isInternalCall or $isCoreCall in previous v9+ deprecations already, and people seemed fine with it). -
Andreas Kienast uploaded patch set 6
V +111/28/22, 13:28 -
Andreas Kienast commented on patch set 6 11/28/22, 13:29
PageRenderer.php:570ReplyAck -
core-ci voted on patch set 6 V +1 11/28/22, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34318
-
Andreas Kienast voted on patch set 6 V +1 CR +1 11/28/22, 13:42
-
Susi Moog commented on patch set 7
CR +1V +111/28/22, 14:18Published edit on patch set 6. -
Susi Moog voted on patch set 7 V +1 CR +1 11/28/22, 14:23
-
Andreas Kienast voted on patch set 7 V +2 CR +2 11/28/22, 14:24
-
core-ci voted on patch set 7 V +1 11/28/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34320
-
Andreas Kienast merged patch set 8 11/28/22, 14:30
PageRenderer.php:570