Review main Merged

76768[TASK] Deprecate config.baseURL

Benni Mack CR +2 V +2 Normal +123 −12 updated 11/28/22, 14:30

Commit message

The methods:
TSFE->wrapBaseUrl()
PageRenderer->setBaseUrl()

and the TypoScript setting config.baseURL are
set to be removed, as the <base> tag has its drawback
with Crawlers and with Site Handling, proper
links with "config.absRefPrefix=auto" or the global
"config.forceAbsoluteUrls = 1" (available in v12.1),
solve all use cases nowadays.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1421

  1. Benni Mack uploaded patch set 1 11/22/22, 21:45

  2. core-ci voted on patch set 1 V -1 11/22/22, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34084

  3. Benni Mack uploaded patch set 2 V -1 11/23/22, 09:25

  4. core-ci voted on patch set 2 V +1 11/23/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34106

  5. Benni Mack updated the commit message in patch set 3 V +1 11/23/22, 10:10

  6. core-ci voted on patch set 3 V +1 11/23/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34108

  7. Benni Mack updated the commit message in patch set 4 V +1 11/23/22, 16:49

  8. core-ci voted on patch set 4 V +1 11/23/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34123

  9. Benni Mack uploaded patch set 5 V +1 11/25/22, 21:48

  10. core-ci voted on patch set 5 V +1 11/25/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34245

  11. Andreas Kienast commented on patch set 5 11/26/22, 19:24

    PageRenderer.php:570

    Would it make sense to get the caller trace and check if the calling method is from a TYPO3 namespace?
  12. Benni Mack commented on patch set 5 11/27/22, 14:10

    PageRenderer.php:570 Reply

    sure, but that's much more code (= and perf penalty) when using this option in v12 :) I could imagine that's a bit overkill for this deprecation. (we've been using the $isInternalCall or $isCoreCall in previous v9+ deprecations already, and people seemed fine with it).
  13. Andreas Kienast uploaded patch set 6 V +1 11/28/22, 13:28

  14. Andreas Kienast commented on patch set 6 11/28/22, 13:29

    PageRenderer.php:570 Reply

    Ack
  15. core-ci voted on patch set 6 V +1 11/28/22, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34318

  16. Andreas Kienast voted on patch set 6 V +1 CR +1 11/28/22, 13:42

  17. Susi Moog commented on patch set 7 CR +1 V +1 11/28/22, 14:18

    Published edit on patch set 6.
  18. Susi Moog voted on patch set 7 V +1 CR +1 11/28/22, 14:23

  19. Andreas Kienast voted on patch set 7 V +2 CR +2 11/28/22, 14:24

  20. core-ci voted on patch set 7 V +1 11/28/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34320

  21. Andreas Kienast merged patch set 8 11/28/22, 14:30