76769[FEATURE] Add "Edit Metadata" button to element information view
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2940
Show 1015 earlier messages
-
Stefan Froemken uploaded patch set 1 11/23/22, 11:19
-
Andreas Kienast commented on patch set 1 11/23/22, 11:24
-
core-ci voted on patch set 1 V -1 11/23/22, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34109
-
Stefan Froemken uploaded patch set 2
V -111/23/22, 12:34 -
core-ci voted on patch set 2 V -1 11/23/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34111
-
Stefan Froemken commented on patch set 2 11/23/22, 12:43
Good pointElementInformationController.php:194ReplyDone -
Stefan Froemken uploaded patch set 3
V -111/23/22, 12:47 -
core-ci voted on patch set 3 V +1 11/23/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34112
-
Chris Müller uploaded patch set 4
V +112/04/22, 18:18 -
core-ci voted on patch set 4 V +1 12/04/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34611
-
Benni Mack commented on patch set 5
V +112/06/22, 10:49Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 12/06/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34709
-
Guido Schmechel commented on patch set 5 V +1 CR +1 12/15/22, 22:40
Good catch :-) -
Oli Bartsch commented on patch set 5 CR -1 12/16/22, 15:15
ElementInformationController.php:196Please have a look at https://github.com/TYPO3/typo3/blob/main/typo3/sysext/filelist/Classes/FileList.php#L505. I suggest to use the same checks here.ElementInformationController.php:209UriBuilder is already injected as service in this class. -
Stefan Froemken uploaded patch set 6
CR +1V +112/20/22, 07:52
-
Stefan Froemken commented on patch set 5 12/20/22, 07:52
ElementInformationController.php:196ReplyPlease follow isEditMetadataAllowed(). It already checks, if user has rights to edit sys_file_metadataElementInformationController.php:209ReplyDone -
core-ci voted on patch set 6 V +1 12/20/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35239
-
Stefan Froemken commented on patch set 6 05/22/23, 08:37
ElementInformationController.php:196ReplyCan you please verify again? Or remove your -1? -
Oli Bartsch commented on patch set 6 05/24/23, 05:52
ElementInformationController.php:196ReplyI can't follow TBH. The method is not called in the current patch, or do I miss something? -
Jasmina Ließmann uploaded patch set 7
V +106/07/23, 09:24 -
core-ci voted on patch set 7 V +1 06/07/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42259
-
Jasmina Ließmann uploaded patch set 8
V +106/07/23, 09:58 -
Jasmina Ließmann commented on patch set 8 06/07/23, 10:00
I rebased the patch and swapped the label on the new button to clarify the purpose. The file metadata could already be edited in the "References to this item" section below. The following point is still open: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76769/comment/3c4b6d40_321422c0/ -
core-ci voted on patch set 8 V +1 06/07/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42262
-
Benni Mack commented on patch set 8 07/04/23, 12:11
Funny enough... I just had an issue today where somebody edited a relation within the ViewPopup and in there, they couldn't open the "change link" modal (because it was in a modal already). -
Oli Bartsch uploaded patch set 9
V +109/19/23, 17:50 -
Oli Bartsch commented on patch set 9 V +1 CR +1 09/19/23, 17:50
ElementInformationController.php:196ReplyDone -
Oliver Hader commented on patch set 9 09/19/23, 18:00
RST path should be changed (`12.2` → `13.0`) -
Oli Bartsch uploaded patch set 10
CR +1V +109/19/23, 18:01 -
Oli Bartsch commented on patch set 10 V +1 CR +1 09/19/23, 18:02
Reply
Done -
Oliver Hader voted on patch set 10 CR +1 09/19/23, 18:02
-
core-ci voted on patch set 9 V +1 09/19/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46815
-
Stefan Bürk voted on patch set 10 CR -1 09/19/23, 18:08
-
Stefan Bürk commented on patch set 11
CR +1V +109/19/23, 18:10Published edit on patch set 10. -
Stefan Bürk voted on patch set 11 V +1 CR +1 09/19/23, 18:10
-
core-ci voted on patch set 10 V +1 09/19/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46818
-
Oli Bartsch voted on patch set 11 V +1 CR +1 09/19/23, 18:12
-
core-ci voted on patch set 11 V +1 09/19/23, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46820
-
Stefan Bürk voted on patch set 11 V +2 CR +2 09/19/23, 18:19
-
Stefan Bürk merged patch set 12 09/19/23, 18:19
ElementInformationController.php:194