Review main Merged

76770[TASK] Clean up extension manager controllers

Benni Mack CR +2 V +2 Hard +132 −182 updated 11/23/22, 16:14

Commit message

This change uses
* constructor property promotion and DI consistently
* types instead of type hints

in all ExtensionMananger/*Controller classes
and the Status Reports of EXT:extensionmanager.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1114

  1. Benni Mack uploaded patch set 1 11/23/22, 11:50

  2. core-ci voted on patch set 1 V -1 11/23/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34110

  3. Benni Mack uploaded patch set 2 V -1 11/23/22, 13:50

  4. core-ci voted on patch set 2 V +1 11/23/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34113

  5. Benni Mack updated the commit message in patch set 3 V +1 11/23/22, 15:03

  6. Susi Moog voted on patch set 3 CR +1 11/23/22, 15:05

  7. core-ci voted on patch set 3 V +1 11/23/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34115

  8. Andreas Kienast voted on patch set 3 CR +1 11/23/22, 15:25

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 11/23/22, 15:29

  10. Oliver Klee voted on patch set 3 CR +1 11/23/22, 15:46

  11. Andreas Kienast voted on patch set 3 V +1 11/23/22, 15:56

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 11/23/22, 16:06

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 11/23/22, 16:14

  14. Christian Kuhn merged patch set 4 11/23/22, 16:14