Review refs/meta/config Abandoned

76783Remove configuration of plugin slack-integration

Stephan Großberndt CR 0 V 0 Easy +0 −9 updated 11/20/23, 15:42

Commit message

The plugin is no longer installed. It was supposed
to replace the Slack functionality of Botty, but it
did not allow messages to multiple channels.
It has since been replaced by gerrit-ci-adapter.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 18

  1. Stephan Großberndt uploaded patch set 1 11/28/22, 08:37

  2. Stephan Großberndt commented on patch set 2 11/28/22, 08:37

    Published edit on patch set 1.
  3. Stephan Großberndt updated the commit message in patch set 3 11/28/22, 08:37

  4. Stephan Großberndt commented on patch set 3 11/28/22, 08:38

    This change is ready for review.
  5. Stephan Großberndt updated the commit message in patch set 4 11/28/22, 08:42

  6. Andri Steiner commented on patch set 4 11/28/22, 08:55

    I'm not allowed to vote here, but it looks good to me.
  7. Stefan Bürk commented on patch set 4 11/28/22, 09:12

    Not allowed to vote. But generally said, removing a superflous configuration for a no-longer installed (and used) plugin seems to ba a valid houskeeping task. From reading this should be okay, but no experience with having gerrit running. The commit message already states, that we have the single core-dev channel message implemented in gerrit-adapter, that we we have some kind of influence how to deal with it. Born because botty failed to resurrect from the death and we needed the message in the core-dev channel. So, from my side go for it - also I'm only a small voice here ;)
  8. Oliver Klee commented on patch set 4 07/16/23, 11:14

    How should we continue here?
  9. Stephan Großberndt commented on patch set 4 09/27/23, 15:18

    @benni: Are you allowed to merge this?
  10. Benni Mack commented on patch set 4 09/27/23, 15:41

    can't merge or vote
  11. Simon Schaufelberger commented on patch set 4 09/27/23, 20:44

    There is also a "Releases" tag missing
  12. Simon Schaufelberger commented on patch set 4 09/27/23, 20:45

    Reply

    and all the rest of the commit message rules that we have... ;)
  13. Simon Schaufelberger commented on patch set 4 09/27/23, 20:56

    I guess it is because of the wrong target branch. Can somebody change that to "main"?
  14. Benni Mack commented on patch set 4 09/27/23, 21:37

    Simon, this patch is Gerrit-internal related, not in the Core repo.
  15. Stefan Bürk commented on patch set 4 09/27/23, 22:56

    Reply

    This is about a gerrit project configuration change. Therefore, "main" would be the wrong branch.

    Reply

    This is not a normal core change, therefore core contribution rules does not apply here. It's a gerrit maintenance / configuration change.

    Reply

    @Stephan Maybe there is some hickup as this ended up in the review proces but no one has rights to vote(verify) for `refs/meta/*`. Searched a little, basically it may be possible to directly push this change for someone having access to to it (Benni/Oliver Hader ?). See SO: https://stackoverflow.com/a/22229537/13131162 See gist: https://gist.github.com/smirn0v/b8e6c4bedebed23a0328 I guess this change here is kind of "stucked". Maybe let's have a call the next days/next week about it, eventually togheter with Benni.
  16. Stephan Großberndt commented on patch set 4 09/28/23, 08:11

    There is a feature in gerrit to edit this configuration via the UI, that is how I created this change, but apparently due to merge access permissions it isn't possible to merge it here. I'll abandon this change and instead apply the according patch directly to the repository on the Gerrit server. Thanks for checking!
  17. Stephan Großberndt abandoned the change 09/28/23, 08:12

    Merging not possible, will be applied manually to the repository on the Gerrit server instead.
  18. Stephan Großberndt commented on patch set 4 11/20/23, 15:42

    Manually applied this change to meta/config

    Reply

    Done