Review main Merged

76800[BUGFIX] Lock `DeferredAction` and recover original label

Andreas Kienast CR +2 V +2 Easy +11 −5 updated 11/25/22, 09:46

Commit message

When a `DeferredAction` is executed, the related action trigger is now
disabled when invoked to prevent multiple executions.
Once the action is done, the button is unlocked and the original label
is rendered again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 11/24/22, 08:17

  2. core-ci voted on patch set 1 V +1 11/24/22, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34157

  3. Benni Mack commented on patch set 1 11/24/22, 08:54

    would only do this for v12
  4. Andreas Kienast updated the commit message in patch set 2 V +1 11/24/22, 09:10

  5. core-ci voted on patch set 2 V +1 11/24/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34162

  6. Benni Mack voted on patch set 2 V +1 CR +1 11/24/22, 12:28

  7. Andreas Kienast commented on patch set 2 CR -1 11/25/22, 09:26

    Need to check something else
  8. Andreas Kienast commented on patch set 2 CR 0 11/25/22, 09:36

    Will adjust https://review.typo3.org/c/Packages/TYPO3.CMS/+/76818 once this patch is merged.
  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/25/22, 09:42

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 11/25/22, 09:46

  11. Andreas Kienast merged patch set 3 11/25/22, 09:46