Review main Merged

76815[TASK] AdminPanel: Group sql queries made by PageRepository

Christoph Lehmann CR +2 V +2 Easy +2 −2 updated 11/28/22, 10:10

Commit message

With this the list of grouped sql queries is
much shorter and better understandable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christoph Lehmann +1
    • Susi Moog +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. Christoph Lehmann uploaded patch set 1 11/24/22, 22:32

  2. Christoph Lehmann updated the commit message in patch set 2 11/24/22, 22:36

  3. core-ci voted on patch set 1 V -1 11/24/22, 22:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34181

  4. core-ci voted on patch set 2 V -1 11/24/22, 22:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34182

  5. Stefan Bürk commented on patch set 2 CR -1 11/25/22, 04:46

    on it

    PageRepository.php:298

    Please use `Connection::PARAM_INT` as doctrine/dbal depreacted support for \PDO values. And we already changed that in core recently. Additionally, type cast *must* not be removed here. It's not ensured that $uid is a int, and thus this is failing for postgres - as it's strict about it.

    PageRepository.php:349

    Please use `Connection::PARAM_INT` as doctrine/dbal depreacted support for \PDO values. And we already changed that in core recently. Additionally, type cast *must* not be removed here. It's not ensured that $uid is a int, and thus this is failing for postgres - as it's strict about it.
  6. Stefan Bürk uploaded patch set 3 CR -1 V -1 11/25/22, 04:47

  7. core-ci voted on patch set 3 V +1 11/25/22, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34188

  8. Stefan Bürk commented on patch set 3 V +1 CR +1 11/25/22, 05:00

    PageRepository.php:298 Reply

    Done

    PageRepository.php:349 Reply

    Done
  9. Stefan Bürk uploaded patch set 4 CR +1 V +1 11/25/22, 05:05

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 11/25/22, 05:06

  11. core-ci voted on patch set 4 V +1 11/25/22, 05:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34190

  12. Andreas Kienast commented on patch set 4 11/25/22, 07:33

    Maybe it's too early for me, but how does introducing named parameters group queries?
  13. Stefan Bürk commented on patch set 4 11/25/22, 07:36

    Reply

    Without, you get queries with the integer directly: ``` SELECT * FROM table WHERE uid = 1; SELECT * FROM table WHERE uid = 2; SELECT * FROM table WHERE uid = 3; ``` Using parameters (named/placeholder) are creating a query in the form of ``` SELECT * from table WHERE uid = ?; // with param 0: 1 SELECT * from table WHERE uid = ?; // with param 0: 2 SELECT * from table WHERE uid = ?; // with param 0: 3 ``` Thus the query can be grouped as it is basicly the same query.
  14. Oliver Klee voted on patch set 4 CR +1 11/25/22, 08:24

  15. Georg Ringer voted on patch set 4 V +1 CR +1 11/25/22, 10:05

  16. Christoph Lehmann commented on patch set 4 CR +1 11/25/22, 11:42

    PageRepository.php:349 Reply

    Thanks for improving it!
  17. Susi Moog voted on patch set 4 V +1 CR +1 11/25/22, 12:19

  18. Stefan Bürk voted on patch set 4 V +2 CR +2 11/25/22, 13:05

  19. Stefan Bürk merged patch set 5 11/25/22, 13:05

  20. Christian Kuhn commented on patch set 5 11/28/22, 10:10

    ah. nice one. saw that as well, lately.