76816[TASK] Streamline ext:redirects auto-create chain
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php2+14 −18
- typo3/sysext/redirects/Classes/RedirectUpdate/PlainSlugReplacementRedirectSource.phpnew+47 −0
- typo3/sysext/redirects/Classes/RedirectUpdate/RedirectSourceCollection.phpnew+50 −0
- typo3/sysext/redirects/Classes/RedirectUpdate/RedirectSourceInterface.phpnew+29 −0
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItem.phpnew+102 −0
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItemFactory.phpnew+66 −0
- typo3/sysext/redirects/Classes/Service/SlugService.php3+90 −62
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_pages_test1.csv+10 −10
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_pages_test2.csv+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_pages_test3.csv+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php2+48 −18
- typo3/sysext/redirects/Tests/Unit/RedirectUpdate/RedirectSourceCollectionTest.phpnew+67 −0
- typo3/sysext/redirects/Tests/Unit/RedirectUpdate/SlugRedirectChangeItemTest.phpnew+62 −0
Review log 2741
Show 1016 earlier messages
-
Stefan Bürk uploaded patch set 1 11/25/22, 05:55
-
core-ci voted on patch set 1 V -1 11/25/22, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34191
-
Stefan Bürk uploaded patch set 2
V -111/25/22, 07:39 -
core-ci voted on patch set 2 V +1 11/25/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34194
-
Stefan Bürk updated the commit message in patch set 3
V +111/25/22, 07:51 -
core-ci voted on patch set 3 V +1 11/25/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34195
-
Nikita Hovratov uploaded patch set 4
V +111/25/22, 12:14 -
Nikita Hovratov uploaded patch set 5 11/25/22, 12:15
-
Nikita Hovratov commented on patch set 5 11/25/22, 12:17
-
core-ci voted on patch set 5 V +1 11/25/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34211
-
core-ci voted on patch set 4 V +1 11/25/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34210
-
Stefan Bürk commented on patch set 5 CR -1 11/25/22, 13:23
DataHandlerSlugUpdateHook.php:36Mhh .. not really correct, as it is the full record, not only the slug anymore. Will come up with a push on weekend with the rest.SlugService.php:133ReplyMh .. not sure. Will re-think it on the weekend. Anyway, thanks for the input. -
Stefan Bürk uploaded patch set 6
CR -1V +111/26/22, 14:21 -
Stefan Bürk commented on patch set 6 11/26/22, 14:22
DataHandlerSlugUpdateHook.php:36ReplyDoneSlugService.php:133ReplyThis was a good point. Thanks for hinting on this. It's quite better with a class, and much more cleaner. -
core-ci voted on patch set 6 V +1 11/26/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34259
-
Nikita Hovratov voted on patch set 6 CR +1 11/26/22, 22:00
-
Stefan Bürk uploaded patch set 7
CR +1V +111/27/22, 21:03 -
core-ci voted on patch set 7 V +1 11/27/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34289
-
Stefan Bürk uploaded patch set 8
V +111/27/22, 21:48 -
Stefan Bürk uploaded patch set 9 11/27/22, 21:52
-
core-ci voted on patch set 8 V +1 11/27/22, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34290
-
core-ci voted on patch set 9 V +1 11/27/22, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34291
-
Stefan Bürk uploaded patch set 10
V +111/27/22, 22:13 -
core-ci voted on patch set 10 V +1 11/27/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34292
-
Benni Mack commented on patch set 10 11/28/22, 09:22
ChangeItem.php:29I have the feeling we should rename this class - "RedirectChangeItem" or "PageRedirectChangeItem". It is related to Pages, Slugs, Redirects... -
Nikita Hovratov commented on patch set 10 11/29/22, 13:23
PlainSlugReplacementSource.php:21what is combat?SourcesCollection.php:23Sorry, another naming thing: How about `SourceCollection`? Collection already implies plural.SourcesCollection.php:50Implement \Countable Interface? -
Benni Mack uploaded patch set 11
V +112/03/22, 21:18 -
core-ci voted on patch set 11 V +1 12/03/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34594
-
Benni Mack commented on patch set 11 V +1 CR +1 12/03/22, 21:46
ChangeItem.php:29ReplyDonePlainSlugReplacementSource.php:21ReplyDoneSourcesCollection.php:23ReplyDoneSourcesCollection.php:50ReplyDone -
Nikita Hovratov uploaded patch set 12
CR +1V +112/05/22, 18:38 -
Nikita Hovratov commented on patch set 12 12/05/22, 18:45
SlugServiceTest.php:502We have this duplicate code now. Should we create a factory class for this? -
core-ci voted on patch set 12 V +1 12/05/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34645
-
Nikita Hovratov uploaded patch set 13
V +112/05/22, 19:03 -
Nikita Hovratov commented on patch set 13 12/05/22, 19:04
SlugServiceTest.php:502ReplyDone -
Nikita Hovratov uploaded patch set 14 12/05/22, 19:06
-
core-ci voted on patch set 14 V +1 12/05/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34647
-
core-ci voted on patch set 13 V -1 12/05/22, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34646
-
Nikita Hovratov voted on patch set 14 V +1 CR +1 12/05/22, 19:24
-
Benni Mack voted on patch set 14 V +1 CR +1 12/05/22, 22:37
-
Stefan Bürk voted on patch set 14 V +2 CR +2 12/05/22, 22:38
-
Stefan Bürk merged patch set 15 12/05/22, 22:38
SlugService.php:133