Review main Merged

76822[FEATURE] Extend stdWrap.if feature

Benni Mack CR +2 V +2 Normal +126 −15 updated 11/27/22, 14:08

Commit message

This change extends the TypoScript
function "if." (checkIf) to also allow
* "contains"
* "startsWith"
* "endsWith"

Examples:

    10 = TEXT
    10.value = Welcome to our website!
    10.if.value.data = page:title
    10.if.startsWith = Home

    10 = TEXT
    10.value = This is an article from Benji
    10.if.value.data = page:author
    10.if.endsWith = Kott

    10 = TEXT
    10.value = Watch Out for Links in this text
    10.if.value.data = field:bodytext
    10.if.contains = https://

In addition, some internal variables
in PHP are renamed to make the code
more readable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1829

Show 4 earlier messages
  1. Benni Mack uploaded patch set 1 11/25/22, 12:45

  2. Benni Mack uploaded patch set 2 11/25/22, 12:47

  3. Benni Mack uploaded patch set 3 11/25/22, 12:50

  4. Benni Mack uploaded patch set 4 11/25/22, 12:50

  1. Benni Mack updated the commit message in patch set 5 11/25/22, 12:57

  2. core-ci voted on patch set 1 V -1 11/25/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34215

  3. core-ci voted on patch set 2 V -1 11/25/22, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34217

  4. core-ci voted on patch set 3 V -1 11/25/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34218

  5. core-ci voted on patch set 4 V -1 11/25/22, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34219

  6. core-ci voted on patch set 5 V -1 11/25/22, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34221

  7. Benni Mack uploaded patch set 6 V -1 11/25/22, 17:14

  8. core-ci voted on patch set 6 V +1 11/25/22, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34238

  9. Benni Mack updated the commit message in patch set 7 V +1 11/25/22, 17:35

  10. core-ci voted on patch set 7 V +1 11/25/22, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34239

  11. Benni Mack uploaded patch set 8 V +1 11/25/22, 22:10

  12. core-ci voted on patch set 8 V +1 11/25/22, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34246

  13. Georg Ringer commented on patch set 8 V +1 CR -1 11/26/22, 09:03

    Feature-99194-SupportForVariousStringComparisonsForStdWrapifTypoScriptFunction.rst:43

    even though it is just an example, please add htmlSpecialChars = 1 to educate people and to avoid security risks by copy paste. also below
  14. Nikita Hovratov uploaded patch set 9 CR -1 V +1 11/26/22, 14:28

  15. Nikita Hovratov commented on patch set 9 V +1 CR +1 11/26/22, 14:29

    Feature-99194-SupportForVariousStringComparisonsForStdWrapifTypoScriptFunction.rst:43 Reply

    Done
  16. core-ci voted on patch set 9 V +1 11/26/22, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34260

  17. Stefan Bürk commented on patch set 10 CR +1 V +1 11/26/22, 14:50

    Published edit on patch set 9.
  18. Stefan Bürk voted on patch set 10 V +1 CR +1 11/26/22, 14:51

  19. core-ci voted on patch set 10 V +1 11/26/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34261

  20. Nikita Hovratov uploaded patch set 11 CR +1 V +1 11/26/22, 21:36

  21. Nikita Hovratov voted on patch set 11 V +1 CR +1 11/26/22, 21:37

  22. core-ci voted on patch set 11 V +1 11/26/22, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34268

  23. Stefan Bürk voted on patch set 11 V +1 CR +1 11/27/22, 05:13

  24. Benni Mack voted on patch set 11 V +2 CR +2 11/27/22, 14:08

  25. Benni Mack merged patch set 12 11/27/22, 14:08