Review main Merged

76824[BUGFIX] Wrap action callback in Promise

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 11/25/22, 14:06

Commit message

The changes of #99176 and #99189 logically conflicted with each other.
The former resets the state of the DeferredAction by using `finally()`,
while the latter one introduces special handling when returning anything
that's not a Promise, leading to issues due to the bound `finally()`
call.

The callback execution itself is now resolved with a new Promise object,
making `finally()` functional again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/25/22, 13:57

  2. core-ci voted on patch set 1 V +1 11/25/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34224

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/25/22, 14:06

  4. Benni Mack merged patch set 2 11/25/22, 14:06