Review main Abandoned

76826[FEATURE] Search slug column in page tree search

Christian Weiske CR 0 V 0 Easy +4 −0 updated 08/24/23, 15:13

Commit message

Search the "slug" pages column in addition to uid, title and nav_title
in the backend page tree search functionality.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Christian Weiske uploaded patch set 1 11/25/22, 14:26

  2. core-ci voted on patch set 1 V -1 11/25/22, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34231

  3. Georg Ringer commented on patch set 1 V -1 CR -1 11/25/22, 15:59

    i asked for something like that on twitter recently as I also thought it might be a good idea but it is imo not, especially on bigger sites this will produce so many false positives that it will make the search unusuable. imagine a tree like root - news & magazine -- news -- magazine ---- 2022 ---- archive and you search for "news", all records will be returned because the segments of the parents is included as well. If we don't use a like search but maybe a strict check (take the leading / into account as well) than it could be a real benefit
  4. Benni Mack commented on patch set 1 11/25/22, 20:48

    Reply

    Yes, I remember. I can also imagine using a userTSconfig option to select the things you want to search for options.pagetree.searchFields { slug = exactMatch title = contains nav_title = contains author = beginsWith } ?
  5. Georg Ringer commented on patch set 1 11/26/22, 09:05

    Reply

    instead of a a configurable list I would be more in favor of an event (if not exist already) to give users the option to write more sophisticated queries
  6. Guido Schmechel commented on patch set 1 11/27/22, 18:50

    Reply Unresolved

    +1 for an event
  7. Simon Schaufelberger commented on patch set 1 08/24/23, 15:03

    Unresolved

    Christian, do you want to implement this requested Event?
  8. Christian Weiske abandoned the change 08/24/23, 15:13