76834[TASK] Avoid usage of superglobal $_COOKIE in favor of PSR-7
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+4 −4
- typo3/sysext/adminpanel/Classes/Modules/Info/RequestInformation.php+4 −4
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Session/UserSessionManager.php+2 −0
- typo3/sysext/core/Documentation/Changelog/11.0/Feature-93023-IntroduceUserSessionAndUserSessionManager.rst+2 −1
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-99201-UserSessionManager-createFromGlobalCookieOrAnonymous.rstnew+50 −0
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+0 −1
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+6 −6
- typo3/sysext/install/Classes/Middleware/Installer.php+2 −2
- typo3/sysext/install/Classes/Middleware/Maintenance.php+11 −11
- typo3/sysext/install/Classes/Service/SessionService.php+16 −13
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1318
-
Benni Mack uploaded patch set 1 11/25/22, 23:05
-
Benni Mack updated the commit message in patch set 2 11/25/22, 23:14
-
core-ci voted on patch set 1 V +1 11/25/22, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34248
-
core-ci voted on patch set 2 V +1 11/25/22, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34249
-
Benni Mack uploaded patch set 3
V +111/27/22, 15:03 -
core-ci voted on patch set 3 V +1 11/27/22, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34282
-
Stefan Bürk uploaded patch set 4
V +111/27/22, 19:17 -
Stefan Bürk commented on patch set 4 11/27/22, 19:19
That would leave following usages for a dedicated patch: * `\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication->isCookieSet()` * `\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication->getCookie()` Correct and intented - or an oversight ? -
core-ci voted on patch set 4 V +1 11/27/22, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34288
-
Benni Mack commented on patch set 4 11/28/22, 08:03
Reply
That is correct, as this change reduces the usages, which are non-breaking :) -
Benni Mack updated the commit message in patch set 5
V +111/28/22, 08:03 -
core-ci voted on patch set 5 V +1 11/28/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34303
-
Benni Mack commented on patch set 5 11/28/22, 08:11
Reply
Done -
Stefan Bürk commented on patch set 5 11/28/22, 08:12
Reply
Ack -
Stefan Bürk voted on patch set 5 V +1 CR +1 11/28/22, 08:13
-
Andreas Kienast voted on patch set 5 V +1 CR +1 11/28/22, 11:39
-
Benni Mack voted on patch set 5 V +2 CR +2 11/28/22, 11:39
-
Benni Mack merged patch set 6 11/28/22, 11:39