Review main Merged

76834[TASK] Avoid usage of superglobal $_COOKIE in favor of PSR-7

Benni Mack CR +2 V +2 Normal +106 −44 updated 11/28/22, 11:39

Commit message

This change reduces most usages of the
superglobal "$_COOKIE" in TYPO3 Core
in favor of PSR-7 $request->getCookieParams().

The previously used
> UserSessionManager->createFromGlobalCookieOrAnonymous
method is marked as deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1318

  1. Benni Mack uploaded patch set 1 11/25/22, 23:05

  2. Benni Mack updated the commit message in patch set 2 11/25/22, 23:14

  3. core-ci voted on patch set 1 V +1 11/25/22, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34248

  4. core-ci voted on patch set 2 V +1 11/25/22, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34249

  5. Benni Mack uploaded patch set 3 V +1 11/27/22, 15:03

  6. core-ci voted on patch set 3 V +1 11/27/22, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34282

  7. Stefan Bürk uploaded patch set 4 V +1 11/27/22, 19:17

  8. Stefan Bürk commented on patch set 4 11/27/22, 19:19

    That would leave following usages for a dedicated patch: * `\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication->isCookieSet()` * `\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication->getCookie()` Correct and intented - or an oversight ?
  9. core-ci voted on patch set 4 V +1 11/27/22, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34288

  10. Benni Mack commented on patch set 4 11/28/22, 08:03

    Reply

    That is correct, as this change reduces the usages, which are non-breaking :)
  11. Benni Mack updated the commit message in patch set 5 V +1 11/28/22, 08:03

  12. core-ci voted on patch set 5 V +1 11/28/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34303

  13. Benni Mack commented on patch set 5 11/28/22, 08:11

    Reply

    Done
  14. Stefan Bürk commented on patch set 5 11/28/22, 08:12

    Reply

    Ack
  15. Stefan Bürk voted on patch set 5 V +1 CR +1 11/28/22, 08:13

  16. Andreas Kienast voted on patch set 5 V +1 CR +1 11/28/22, 11:39

  17. Benni Mack voted on patch set 5 V +2 CR +2 11/28/22, 11:39

  18. Benni Mack merged patch set 6 11/28/22, 11:39