Review main Merged

76835[TASK] Replace prophecy in EXT:extensionmanager InstallUtilityTest

Torben Hansen CR +2 V +2 Normal +41 −44 updated 11/26/22, 20:51

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Torben Hansen uploaded patch set 1 11/26/22, 12:13

  2. core-ci voted on patch set 1 V +1 11/26/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34255

  3. Oliver Klee voted on patch set 1 V +1 11/26/22, 12:24

  4. Oliver Klee commented on patch set 1 11/26/22, 12:28

    InstallUtilityTest.php:99

    $cacheManagerProphecy -> $cacheManagerMock
  5. Torben Hansen uploaded patch set 2 V +1 11/26/22, 12:48

  6. Torben Hansen commented on patch set 1 11/26/22, 12:48

    InstallUtilityTest.php:99 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/26/22, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34256

  8. Nikita Hovratov commented on patch set 2 11/26/22, 13:52

    InstallUtilityTest.php:393

    Before it was tested with `shouldNotBeCalled`, so this makes sense that it fails. I think we can remove the comment.
  9. Oliver Klee voted on patch set 2 V +1 CR +1 11/26/22, 14:14

  10. Stefan Bürk commented on patch set 2 CR -1 11/26/22, 14:26

    InstallUtilityTest.php:393 Reply

    We should add a expects(self::never()) as replacement - as this one is part of the test I would say.
  11. Nikita Hovratov commented on patch set 2 11/26/22, 14:33

    InstallUtilityTest.php:393 Reply

    Doesn't work anymore with phpunit. The `set` method is called, but with another argument. And phpunit doesn't take the argument into consideration, but only checks if the method is really never called. IMO it's fine to test here for the exact opposite.
  12. Stefan Bürk commented on patch set 2 CR 0 11/26/22, 14:47

    InstallUtilityTest.php:393 Reply

    What the heck ... ok then. Ack.
  13. Stefan Bürk voted on patch set 2 V +1 CR +1 11/26/22, 14:48

  14. Nikita Hovratov voted on patch set 2 V +2 CR +2 11/26/22, 20:51

  15. Nikita Hovratov merged patch set 3 11/26/22, 20:51