Review main Merged

76844[FEATURE] Enable select item groups through TSconfig

TYPO3com CR +2 V +2 Normal +115 −8 updated 12/02/22, 16:36

Commit message

With this change you're able to use TCA select item groups within
Page TSconfig in TCEFORM section like

   TCEFORM.tx_myext_domain_model_a.record_type.addItems {
     1 = item label
     1.icon = icon-identifier
     1.group = tx_myext_group
   }

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1120

  1. TYPO3com uploaded patch set 1 11/28/22, 14:02

  2. core-ci voted on patch set 1 V +1 11/28/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34319

  3. Sebastian Iffland updated the commit message in patch set 2 V +1 11/28/22, 14:20

  4. core-ci voted on patch set 2 V +1 11/28/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34321

  5. Sebastian Iffland updated the commit message in patch set 3 V +1 12/01/22, 06:50

  6. core-ci voted on patch set 3 V +1 12/01/22, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34461

  7. Benni Mack commented on patch set 3 12/01/22, 11:50

    Thanks for the patch, I think this is a great idea. Features only go into "main", we do not add new features to LTS releases. Also, we need an RST file. Can you provide that?
  8. Sebastian Iffland updated the commit message in patch set 4 V +1 12/01/22, 11:51

  9. core-ci voted on patch set 4 V +1 12/01/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34481

  10. Benni Mack uploaded patch set 5 V +1 12/01/22, 12:07

  11. Benni Mack uploaded patch set 6 12/01/22, 12:12

  12. Christian Kuhn updated the commit message in patch set 7 12/01/22, 12:12

  13. core-ci voted on patch set 6 V +1 12/01/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34484

  14. core-ci voted on patch set 5 V +1 12/01/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34482

  15. core-ci voted on patch set 7 V -1 12/01/22, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34485

  16. Benni Mack rebased onto patch set 8 V -1 12/01/22, 21:15

  17. core-ci voted on patch set 8 V +1 12/01/22, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34526

  18. Benni Mack voted on patch set 8 V +1 CR +1 12/01/22, 21:27

  19. Stefan Bürk voted on patch set 8 V +2 CR +2 12/02/22, 16:36

  20. Stefan Bürk merged patch set 9 12/02/22, 16:36