Review main Merged

76845[TASK] Highlight content elements in inconsistent translation state

Annett Jähnichen CR +2 V +2 Easy +18 −2 updated 12/06/22, 13:38

Commit message

In the "Page" module, translated content elements without a connection
to the original language are highlighted, when a page is in
"Translation" mode and `allowInconsistentLanguageHandling` is disabled.

Additionally, a badge informing about the inconsistent language
state is added.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1523

  1. Annett Jähnichen uploaded patch set 1 11/28/22, 14:54

  2. core-ci voted on patch set 1 V +1 11/28/22, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34323

  3. Annett Jähnichen uploaded patch set 2 V +1 11/28/22, 19:07

  4. core-ci voted on patch set 2 V -1 11/28/22, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34334

  5. Annett Jähnichen uploaded patch set 3 V -1 11/28/22, 20:06

  6. core-ci voted on patch set 3 V +1 11/28/22, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34336

  7. Annett Jähnichen uploaded patch set 4 V +1 11/29/22, 09:53

  8. core-ci voted on patch set 4 V +1 11/29/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34355

  9. Annett Jähnichen uploaded patch set 5 V +1 11/30/22, 09:31

  10. core-ci voted on patch set 5 V +1 11/30/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34396

  11. Andreas Kienast uploaded patch set 6 V +1 11/30/22, 10:58

  12. Andreas Kienast updated the commit message in patch set 7 11/30/22, 11:04

  13. Andreas Kienast marked it ready for review 11/30/22, 11:04

  14. Andreas Kienast voted on patch set 7 V +1 CR +1 11/30/22, 11:04

  15. core-ci voted on patch set 6 V +1 11/30/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34409

  16. core-ci voted on patch set 7 V +1 11/30/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34410

  17. Kevin Appelt voted on patch set 7 CR +1 12/05/22, 09:28

  18. Benni Mack commented on patch set 7 12/05/22, 10:39

    GridColumnItem.php:259

    the whole class is internal, but no prob having it here.
  19. Annett Jähnichen uploaded patch set 8 CR +1 V +1 12/05/22, 13:58

  20. Andreas Kienast commented on patch set 8 V +1 CR +1 12/05/22, 14:06

    GridColumnItem.php:259 Reply

    Done
  21. core-ci voted on patch set 8 V +1 12/05/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34633

  22. Georg Ringer voted on patch set 8 V +2 CR +2 12/06/22, 13:38

  23. Georg Ringer merged patch set 9 12/06/22, 13:38