76854[FEATURE] Add event to modify backend search results
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/backend/live-search/result-types/default-result-type.tsnew+21 −0
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+7 −0
- typo3/sysext/backend/Classes/EventListener/AfterBackendPageRenderEventListener.php+5 −0
- typo3/sysext/backend/Classes/Search/Event/ModifyResultItemInLiveSearchEvent.phpnew+35 −0
- typo3/sysext/backend/Classes/Search/EventListener/AddLiveSearchResultActionsListener.phpnew+84 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+7 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+3 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItem.php+30 −0
- typo3/sysext/backend/Configuration/Services.yaml+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/result-types/default-result-type.jsnew+13 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99220-AddEventToModifySearchResults.rst10new+87 −0
Review log 1521
-
Andreas Kienast uploaded patch set 1 11/29/22, 12:12
-
core-ci voted on patch set 1 V -1 11/29/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34360
-
Andreas Kienast uploaded patch set 2
V -111/29/22, 12:44 -
core-ci voted on patch set 2 V +1 11/29/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34361
-
Benni Mack commented on patch set 2 CR -1 12/02/22, 21:53
Must be a feature -
Andreas Kienast uploaded patch set 3
CR -1V +112/05/22, 14:48 -
Chris Müller uploaded patch set 4 12/05/22, 14:53
-
core-ci voted on patch set 3 V +1 12/05/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34639
-
core-ci voted on patch set 4 V +1 12/05/22, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34640
-
Benni Mack commented on patch set 5
V +112/06/22, 10:48Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 12/06/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34705
-
Guido Schmechel commented on patch set 5 12/15/22, 23:26
Feature-99220-AddEventToModifySearchResults.rst:39Can we add the other imports here? Then the example would be completeFeature-99220-AddEventToModifySearchResults.rst:54I tested the example and pages did not expand for me. Two issues: 1.) The value "table" in getExtraData() was always missing in that case. (No addition in PageRecordProvider) It worked with a tt_content example. 2.) The eventlistener blocks PageRecordProvider: if ($resultItem->getProviderClassName() !== DatabaseRecordProvider::class) { return; } If I adjust the two places, it works.Feature-99220-AddEventToModifySearchResults.rst:58I would suggest we take a real example here to include URL routing. In my example, I had linked the history of the data set. -
Andreas Kienast commented on patch set 5 CR -1 12/16/22, 08:18
Feature-99220-AddEventToModifySearchResults.rst:39ReplyAckFeature-99220-AddEventToModifySearchResults.rst:54ReplyAlright, the example is complete bollocks here. Will update it to use tt_content instead.Feature-99220-AddEventToModifySearchResults.rst:58ReplyAck -
Andreas Kienast uploaded patch set 6
CR -1V +112/16/22, 08:26 -
Andreas Kienast commented on patch set 6 12/16/22, 08:26
Feature-99220-AddEventToModifySearchResults.rst:54ReplyDone -
core-ci voted on patch set 6 V +1 12/16/22, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35188
-
Guido Schmechel commented on patch set 6 12/16/22, 21:33
Feature-99220-AddEventToModifySearchResults.rst:54ReplyThank you! Is it intentional that table pages should not be expanded with the event? -
Andreas Kienast commented on patch set 6 12/17/22, 06:59
Feature-99220-AddEventToModifySearchResults.rst:54ReplyIt‘s meant as an example to show you‘re able to limit the event listener for specific providers. -
Guido Schmechel commented on patch set 6 V +1 CR +1 12/17/22, 14:29
Feature-99220-AddEventToModifySearchResults.rst:54ReplyThanks for your explanation :-) -
Benni Mack voted on patch set 6 V +2 CR +2 12/23/22, 09:48
-
Benni Mack merged patch set 7 12/23/22, 09:48