76857[FEATURE] Add a command to set up TYPO3
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99221-AddCliInstallSetupCommand.rst2new+51 −0
- typo3/sysext/install/Classes/Command/SetupCommand.php2new+610 −0
- typo3/sysext/install/Classes/Controller/InstallerController.php+1 −1
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+2 −2
- typo3/sysext/install/Classes/Service/SetupService.php+3 −1
- typo3/sysext/install/Classes/ServiceProvider.php+16 −0
Review log 3554
Show 1929 earlier messages
-
Jochen Roth uploaded patch set 1 11/29/22, 18:11
-
Jochen Roth uploaded patch set 2 11/29/22, 18:14
-
core-ci voted on patch set 1 V -1 11/29/22, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34367
-
core-ci voted on patch set 2 V -1 11/29/22, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34368
-
Jochen Roth uploaded patch set 3
V -111/29/22, 18:50 -
Oliver Klee commented on patch set 3 11/29/22, 18:52
typo3 -> TYPO3 setup -> set up (the verb is “set up”, while the noun is “setup”) -
core-ci voted on patch set 3 V +1 11/29/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34369
-
Jochen Roth updated the commit message in patch set 4
V +111/29/22, 19:09 -
Oliver Klee commented on patch set 4 11/29/22, 19:12
Reply
Done -
Oliver Klee wrote 11/29/22, 19:12
Removed cc Oliver Klee. -
core-ci voted on patch set 4 V +1 11/29/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34370
-
Benni Mack commented on patch set 4 11/29/22, 21:55
how about we put the "let's move code from the controller into a service" into a pre-patch? -
Jochen Roth uploaded patch set 5
V +111/30/22, 10:20 -
core-ci voted on patch set 5 V -1 11/30/22, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34403
-
Jochen Roth uploaded patch set 6
V -111/30/22, 10:42 -
core-ci voted on patch set 6 V +1 11/30/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34407
-
Jochen Roth uploaded patch set 7
V +111/30/22, 11:12 -
core-ci voted on patch set 7 V -1 11/30/22, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34411
-
Jochen Roth uploaded patch set 8
V -111/30/22, 11:25 -
core-ci voted on patch set 8 V +1 11/30/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34413
-
Josef Glatz commented on patch set 9
V +111/30/22, 13:39Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 11/30/22, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34421
-
Benni Mack rebased onto patch set 10
V +112/01/22, 08:55 -
core-ci voted on patch set 10 V +1 12/01/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34462
-
Benni Mack commented on patch set 10 12/01/22, 10:26
how about just "./bin/typo3 install" ? -
Jochen Roth commented on patch set 10 12/01/22, 12:27
Reply
Maybe "./bin/typo3 setup" ? Because "install" was already done by composer. -
Benni Mack commented on patch set 10 12/01/22, 18:40
Reply
yes -
Jochen Roth uploaded patch set 11
V +112/02/22, 11:32 -
Jochen Roth uploaded patch set 12 12/02/22, 11:41
-
core-ci voted on patch set 11 V -1 12/02/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34557
-
Jochen Roth commented on patch set 12 12/02/22, 11:43
Reply
Done -
core-ci voted on patch set 12 V -1 12/02/22, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34558
-
Jochen Roth uploaded patch set 13
V -112/02/22, 11:50 -
core-ci voted on patch set 13 V -1 12/02/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34559
-
Jochen Roth uploaded patch set 14
V -112/02/22, 12:51 -
core-ci voted on patch set 14 V +1 12/02/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34566
-
Benni Mack commented on patch set 14 12/02/22, 13:06
Feature-99221-AddCliInstallSetupCommand.rst:41let's use "TYPO3_SETUP_ADMIN_EMAIL", "TYPO3_SETUP_ADMIN_USERNAME" and "TYPo3_SETUP_PASSWORD" -
Stefan Bürk commented on patch set 14 12/02/22, 13:08
SetupCommand.php:76Sorry for being late to the party, but I don't like using "connection" here. This is basicly the "driver" used for the connection. Also "$connectionLabels is therefor kind of wrong. If I read "connection", if would mentally relate it to the ConnectionPool name "Default", "Custom1" etc ... Can we use here more "driver" for it (along with $driverLabels) ? And env var name should be therefore `TYPO3_DB_DRIVER` -
Jochen Roth uploaded patch set 15
V +112/02/22, 14:37 -
Jochen Roth commented on patch set 15 12/02/22, 14:42
Rename env vars as requestet. Connection is now named driver. Also renamed options to at least be similar to the env vars.Feature-99221-AddCliInstallSetupCommand.rst:41ReplyDoneSetupCommand.php:76ReplyDone -
core-ci voted on patch set 15 V +1 12/02/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34572
-
Stefan Bürk commented on patch set 15 CR -1 12/02/22, 16:13
on it -
Stefan Bürk uploaded patch set 16
CR -1V +112/02/22, 16:22 -
Stefan Bürk updated the commit message in patch set 17 12/02/22, 16:25
-
core-ci voted on patch set 16 V -1 12/02/22, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34574
-
core-ci voted on patch set 17 V -1 12/02/22, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34575
-
Stefan Bürk uploaded patch set 18
V -112/02/22, 16:51 -
core-ci voted on patch set 18 V +1 12/02/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34577
-
Stefan Bürk voted on patch set 18 V +1 CR +1 12/02/22, 17:19
-
Benni Mack uploaded patch set 19
CR +1V +112/03/22, 20:15 -
Benni Mack voted on patch set 19 V +1 CR +1 12/03/22, 20:16
-
core-ci voted on patch set 19 V +1 12/03/22, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34591
-
Stefan Bürk voted on patch set 19 V +2 CR +2 12/03/22, 20:51
-
Stefan Bürk merged patch set 20 12/03/22, 20:51