Review main Merged

76857[FEATURE] Add a command to set up TYPO3

Jochen Roth CR +2 V +2 Hard +683 −4 updated 12/03/22, 20:51

Commit message

Currently, there is only a GUI installer to set up
a TYPO3 installation. This does not allow to automate
the setup process.

Therefore, a new CLI command named "setup" has been added.

To provide the required information environment variables,
CLI options or a step-by-step walk-through can be used.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 3554

Show 1929 earlier messages
  1. Jochen Roth uploaded patch set 1 11/29/22, 18:11

  2. Jochen Roth uploaded patch set 2 11/29/22, 18:14

  3. core-ci voted on patch set 1 V -1 11/29/22, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34367

  4. core-ci voted on patch set 2 V -1 11/29/22, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34368

  5. Jochen Roth uploaded patch set 3 V -1 11/29/22, 18:50

  6. Oliver Klee commented on patch set 3 11/29/22, 18:52

    typo3 -> TYPO3 setup -> set up (the verb is “set up”, while the noun is “setup”)
  7. core-ci voted on patch set 3 V +1 11/29/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34369

  8. Jochen Roth updated the commit message in patch set 4 V +1 11/29/22, 19:09

  9. Oliver Klee commented on patch set 4 11/29/22, 19:12

    Reply

    Done
  10. Oliver Klee wrote 11/29/22, 19:12

    Removed cc Oliver Klee.
  11. core-ci voted on patch set 4 V +1 11/29/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34370

  12. Benni Mack commented on patch set 4 11/29/22, 21:55

    how about we put the "let's move code from the controller into a service" into a pre-patch?
  13. Jochen Roth uploaded patch set 5 V +1 11/30/22, 10:20

  14. core-ci voted on patch set 5 V -1 11/30/22, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34403

  15. Jochen Roth uploaded patch set 6 V -1 11/30/22, 10:42

  16. core-ci voted on patch set 6 V +1 11/30/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34407

  17. Jochen Roth uploaded patch set 7 V +1 11/30/22, 11:12

  18. core-ci voted on patch set 7 V -1 11/30/22, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34411

  19. Jochen Roth uploaded patch set 8 V -1 11/30/22, 11:25

  20. core-ci voted on patch set 8 V +1 11/30/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34413

  21. Josef Glatz commented on patch set 9 V +1 11/30/22, 13:39

    Published edit on patch set 8.
  22. core-ci voted on patch set 9 V +1 11/30/22, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34421

  23. Benni Mack rebased onto patch set 10 V +1 12/01/22, 08:55

  24. core-ci voted on patch set 10 V +1 12/01/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34462

  25. Benni Mack commented on patch set 10 12/01/22, 10:26

    how about just "./bin/typo3 install" ?
  26. Jochen Roth commented on patch set 10 12/01/22, 12:27

    Reply

    Maybe "./bin/typo3 setup" ? Because "install" was already done by composer.
  27. Benni Mack commented on patch set 10 12/01/22, 18:40

    Reply

    yes
  28. Jochen Roth uploaded patch set 11 V +1 12/02/22, 11:32

  29. Jochen Roth uploaded patch set 12 12/02/22, 11:41

  1. core-ci voted on patch set 11 V -1 12/02/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34557

  2. Jochen Roth commented on patch set 12 12/02/22, 11:43

    Reply

    Done
  3. core-ci voted on patch set 12 V -1 12/02/22, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34558

  4. Jochen Roth uploaded patch set 13 V -1 12/02/22, 11:50

  5. core-ci voted on patch set 13 V -1 12/02/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34559

  6. Jochen Roth uploaded patch set 14 V -1 12/02/22, 12:51

  7. core-ci voted on patch set 14 V +1 12/02/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34566

  8. Benni Mack commented on patch set 14 12/02/22, 13:06

    Feature-99221-AddCliInstallSetupCommand.rst:41

    let's use "TYPO3_SETUP_ADMIN_EMAIL", "TYPO3_SETUP_ADMIN_USERNAME" and "TYPo3_SETUP_PASSWORD"
  9. Stefan Bürk commented on patch set 14 12/02/22, 13:08

    SetupCommand.php:76

    Sorry for being late to the party, but I don't like using "connection" here. This is basicly the "driver" used for the connection. Also "$connectionLabels is therefor kind of wrong. If I read "connection", if would mentally relate it to the ConnectionPool name "Default", "Custom1" etc ... Can we use here more "driver" for it (along with $driverLabels) ? And env var name should be therefore `TYPO3_DB_DRIVER`
  10. Jochen Roth uploaded patch set 15 V +1 12/02/22, 14:37

  11. Jochen Roth commented on patch set 15 12/02/22, 14:42

    Rename env vars as requestet. Connection is now named driver. Also renamed options to at least be similar to the env vars.

    Feature-99221-AddCliInstallSetupCommand.rst:41 Reply

    Done

    SetupCommand.php:76 Reply

    Done
  12. core-ci voted on patch set 15 V +1 12/02/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34572

  13. Stefan Bürk commented on patch set 15 CR -1 12/02/22, 16:13

    on it
  14. Stefan Bürk uploaded patch set 16 CR -1 V +1 12/02/22, 16:22

  15. Stefan Bürk updated the commit message in patch set 17 12/02/22, 16:25

  16. core-ci voted on patch set 16 V -1 12/02/22, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34574

  17. core-ci voted on patch set 17 V -1 12/02/22, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34575

  18. Stefan Bürk uploaded patch set 18 V -1 12/02/22, 16:51

  19. core-ci voted on patch set 18 V +1 12/02/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34577

  20. Stefan Bürk voted on patch set 18 V +1 CR +1 12/02/22, 17:19

  21. Benni Mack uploaded patch set 19 CR +1 V +1 12/03/22, 20:15

  22. Benni Mack voted on patch set 19 V +1 CR +1 12/03/22, 20:16

  23. core-ci voted on patch set 19 V +1 12/03/22, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34591

  24. Stefan Bürk voted on patch set 19 V +2 CR +2 12/03/22, 20:51

  25. Stefan Bürk merged patch set 20 12/03/22, 20:51