76860[TASK] Extract code from InstallerController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon+5 −0
- typo3/sysext/install/Classes/Controller/InstallerController.php+41 −761
- typo3/sysext/install/Classes/Service/SetupDatabaseService.phpnew+700 −0
- typo3/sysext/install/Classes/Service/SetupService.phpnew+221 −0
- typo3/sysext/install/Classes/ServiceProvider.php2+25 −4
- typo3/sysext/install/Configuration/Services.yaml+1 −1
Review log 1014
-
Jochen Roth uploaded patch set 1 11/30/22, 09:54
-
Jochen Roth updated the commit message in patch set 2 11/30/22, 09:59
-
core-ci voted on patch set 2 V +1 11/30/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34402
-
core-ci voted on patch set 1 V +1 11/30/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34401
-
Jochen Roth uploaded patch set 3 11/30/22, 10:42
Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 3 V +1 11/30/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34406
-
Simon Schaufelberger commented on patch set 3 11/30/22, 10:56
ServiceProvider.php:203empty line missing afterwards -
Jochen Roth uploaded patch set 4
V +111/30/22, 11:15 -
Jochen Roth commented on patch set 4 11/30/22, 11:16
ServiceProvider.php:203ReplyDone -
core-ci voted on patch set 4 V +1 11/30/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34412
-
Susi Moog voted on patch set 4 V +1 CR +1 12/01/22, 08:42
-
Benni Mack voted on patch set 4 V +2 CR +2 12/01/22, 08:45
-
Benni Mack merged patch set 5 12/01/22, 08:45
-
Stefan Bürk commented on patch set 5 12/01/22, 08:53
post +1 :)