Review main Merged

76860[TASK] Extract code from InstallerController

Jochen Roth CR +2 V +2 Expert +993 −766 updated 12/01/22, 08:53

Commit message

The InstallerController contains a lot of code
that could be useful in e.g. cli command.

Thus, some code of the controller has been extracted
to service classes for later use in the cli (see #99221)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1014

  1. Jochen Roth uploaded patch set 1 11/30/22, 09:54

  2. Jochen Roth updated the commit message in patch set 2 11/30/22, 09:59

  3. core-ci voted on patch set 2 V +1 11/30/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34402

  4. core-ci voted on patch set 1 V +1 11/30/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34401

  5. Jochen Roth uploaded patch set 3 11/30/22, 10:42

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  6. core-ci voted on patch set 3 V +1 11/30/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34406

  7. Simon Schaufelberger commented on patch set 3 11/30/22, 10:56

    ServiceProvider.php:203

    empty line missing afterwards
  8. Jochen Roth uploaded patch set 4 V +1 11/30/22, 11:15

  9. Jochen Roth commented on patch set 4 11/30/22, 11:16

    ServiceProvider.php:203 Reply

    Done
  10. core-ci voted on patch set 4 V +1 11/30/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34412

  11. Susi Moog voted on patch set 4 V +1 CR +1 12/01/22, 08:42

  12. Benni Mack voted on patch set 4 V +2 CR +2 12/01/22, 08:45

  13. Benni Mack merged patch set 5 12/01/22, 08:45

  14. Stefan Bürk commented on patch set 5 12/01/22, 08:53

    post +1 :)