76861[BUGFIX] uft8 encode text to allow special chars in PDF metadata
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1419
-
Tomas Norre Mikkelsen uploaded patch set 1 11/30/22, 11:41
-
core-ci voted on patch set 1 V +1 11/30/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34414
-
Chris Müller commented on patch set 1 CR -1 11/30/22, 14:56
-
Tomas Norre Mikkelsen commented on patch set 1 11/30/22, 15:08
FileContentParser.php:799ReplySure, didn't think about that. -
Tomas Norre Mikkelsen uploaded patch set 2
CR -1V +111/30/22, 15:34 -
Tomas Norre Mikkelsen commented on patch set 2 11/30/22, 15:34
FileContentParser.php:799ReplyDone -
Andreas Kienast commented on patch set 2 CR -1 11/30/22, 15:37
FileContentParser.php:799I guess you forgot to remove this line? -
core-ci voted on patch set 2 V +1 11/30/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34425
-
Tomas Norre Mikkelsen uploaded patch set 3
CR -1V +111/30/22, 15:44 -
Tomas Norre Mikkelsen commented on patch set 2 11/30/22, 15:44
FileContentParser.php:799ReplyMy bad, wanted to make sure i replaced it correctly. -
Tomas Norre Mikkelsen uploaded patch set 4 11/30/22, 15:46
-
core-ci voted on patch set 4 V +1 11/30/22, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34427
-
core-ci voted on patch set 3 V +1 11/30/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34426
-
Benni Mack commented on patch set 4 12/01/22, 10:38
Thanks for the patch. You do not need the hard requirement in the composer.json as we use the symfony/polyfill-mbstring already, allowing us to use all mb_* functions even if PHP is compiled that way. Adding such a restriction would also not allow (some) existing v10/v11 projects to be updated when we release a patch-level version (although the probability of NOT having mbstring installed is low these days). For this reason, you can remove the change in the composer.json. Apart from that: looks good! -
Tomas Norre Mikkelsen uploaded patch set 5
V +112/01/22, 11:11 -
core-ci voted on patch set 5 V +1 12/01/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34471
-
Benni Mack voted on patch set 5 V +1 CR +1 12/01/22, 11:24
-
Andreas Kienast voted on patch set 5 V +2 CR +2 12/01/22, 11:38
-
Andreas Kienast merged patch set 6 12/01/22, 11:38
FileContentParser.php:799