Review main Merged

76861[BUGFIX] uft8 encode text to allow special chars in PDF metadata

Tomas Norre Mikkelsen CR +2 V +2 Easy +1 −1 updated 12/01/22, 11:38

Commit message

This encodes the PDF metadata to UTF-8 to ensure that special chars
like æ ø å ü ö ä are allowed without cutting of the metadata text.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1419

  1. Tomas Norre Mikkelsen uploaded patch set 1 11/30/22, 11:41

  2. core-ci voted on patch set 1 V +1 11/30/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34414

  3. Chris Müller commented on patch set 1 CR -1 11/30/22, 14:56

    FileContentParser.php:799

    utf8_encode is deprecated with PHP 8.2. So I suggest to use one of the alternatives: https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode#alternatives_to_removed_functionality
  4. Tomas Norre Mikkelsen commented on patch set 1 11/30/22, 15:08

    FileContentParser.php:799 Reply

    Sure, didn't think about that.
  5. Tomas Norre Mikkelsen uploaded patch set 2 CR -1 V +1 11/30/22, 15:34

  6. Tomas Norre Mikkelsen commented on patch set 2 11/30/22, 15:34

    FileContentParser.php:799 Reply

    Done
  7. Andreas Kienast commented on patch set 2 CR -1 11/30/22, 15:37

    FileContentParser.php:799

    I guess you forgot to remove this line?
  8. core-ci voted on patch set 2 V +1 11/30/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34425

  9. Tomas Norre Mikkelsen uploaded patch set 3 CR -1 V +1 11/30/22, 15:44

  10. Tomas Norre Mikkelsen commented on patch set 2 11/30/22, 15:44

    FileContentParser.php:799 Reply

    My bad, wanted to make sure i replaced it correctly.
  11. Tomas Norre Mikkelsen uploaded patch set 4 11/30/22, 15:46

  12. core-ci voted on patch set 4 V +1 11/30/22, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34427

  13. core-ci voted on patch set 3 V +1 11/30/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34426

  14. Benni Mack commented on patch set 4 12/01/22, 10:38

    Thanks for the patch. You do not need the hard requirement in the composer.json as we use the symfony/polyfill-mbstring already, allowing us to use all mb_* functions even if PHP is compiled that way. Adding such a restriction would also not allow (some) existing v10/v11 projects to be updated when we release a patch-level version (although the probability of NOT having mbstring installed is low these days). For this reason, you can remove the change in the composer.json. Apart from that: looks good!
  15. Tomas Norre Mikkelsen uploaded patch set 5 V +1 12/01/22, 11:11

  16. core-ci voted on patch set 5 V +1 12/01/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34471

  17. Benni Mack voted on patch set 5 V +1 CR +1 12/01/22, 11:24

  18. Andreas Kienast voted on patch set 5 V +2 CR +2 12/01/22, 11:38

  19. Andreas Kienast merged patch set 6 12/01/22, 11:38