Review main Merged

76867[TASK] Use unified buttons in Scheduler docheader

Annett Jähnichen CR +2 V +2 Normal +38 −30 updated 12/05/22, 09:10

Commit message

The 'SchedulerTask' module should use
same buttons in docheader as in other modules, therefore
use only 'Close', 'Save and Close', 'Save', 'New' and 'Delete'
and in the correct context.

Leave 'Save and Close' button for now,
until there exist an state handling for closing the form with changes.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Annett Jähnichen uploaded patch set 1 11/30/22, 16:36

  2. core-ci voted on patch set 1 V -1 11/30/22, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34429

  3. Annett Jähnichen uploaded patch set 2 V -1 12/01/22, 15:25

  4. Annett Jähnichen rebased onto patch set 3 12/01/22, 15:28

  5. core-ci voted on patch set 3 V +1 12/01/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34508

  6. core-ci voted on patch set 2 V +1 12/01/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34507

  7. Annett Jähnichen marked it ready for review 12/02/22, 09:08

  8. Andreas Kienast updated the commit message in patch set 4 V +1 12/02/22, 10:22

  9. core-ci voted on patch set 4 V +1 12/02/22, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34551

  10. Benni Mack voted on patch set 4 V +1 CR +1 12/04/22, 20:22

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 12/04/22, 20:53

  12. Annett Jähnichen voted on patch set 4 V +2 CR +2 12/05/22, 09:10

  13. Annett Jähnichen merged patch set 5 12/05/22, 09:10