76869[TASK] Migrate Typo3DbQueryParserTest to functional
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 79
-
Nikita Hovratov uploaded patch set 1 11/30/22, 17:35
-
core-ci voted on patch set 1 V -1 11/30/22, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34434
-
Nikita Hovratov uploaded patch set 2
V -111/30/22, 18:11 -
core-ci voted on patch set 2 V +1 11/30/22, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34436
-
Nikita Hovratov commented on patch set 2 11/30/22, 19:08
This was a heavy one. Little note for reviewers: The tests were changed to test for the public method `convertQueryToDoctrineQueryBuilder` instead of the protected ones. As a result, the queries now need to be checked via regexp, as they are converted for the target dbms now. I don't know if there is a better way. Only way would be to either use the AccessibleMock again or to run the queries and check for the result. None of them makes sense for this case imo, so we are stuck with regex. -
Oliver Klee voted on patch set 2 V +1 12/01/22, 08:29
-
Benni Mack voted on patch set 2 V +1 CR +1 12/01/22, 23:07
-
Stefan Bürk commented on patch set 2 V +2 CR +2 12/02/22, 10:47
Thanks for the work on this -
Stefan Bürk merged patch set 3 12/02/22, 10:47