Review main Merged

76872[TASK] Make type annotations for trait CookieHeaderTrait more specific

Oliver Klee CR +2 V +2 Easy +3 −0 updated 12/01/22, 11:39

Commit message

This fixes 2 of the 4 PHPStan warnings with Symfony 6.2.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Klee uploaded patch set 1 12/01/22, 09:59

  2. core-ci voted on patch set 1 V +1 12/01/22, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34463

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/01/22, 10:52

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 12/01/22, 11:39

  5. Andreas Kienast merged patch set 2 12/01/22, 11:39