Review main Merged

76873[TASK] Require Symfony 6.2

Benni Mack CR +2 V +2 Hard +207 −260 updated 12/01/22, 16:01

Commit message

Symfony 6.2 provides a longer support lifetime
than the currently supported Symfony 6.1.

For this reason the dependencies are changed
as TYPO3 v12 LTS will upgrade to Symfony 6 LTS
at some point (after its release) anyway.

Used composer command:
composer req -W symfony/config:^6.2 \
  symfony/console:^6.2 \
  symfony/dependency-injection:^6.2 \
  symfony/expression-language:^6.2 \
  symfony/filesystem:^6.2 \
  symfony/finder:^6.2 \
  symfony/http-foundation:^6.2 \
  symfony/mailer:^6.2 \
  symfony/mime:^6.2 \
  symfony/options-resolver:^6.2 \
  symfony/property-access:^6.2 \
  symfony/property-info:^6.2 \
  symfony/rate-limiter:^6.2 \
  symfony/routing:^6.2 \
  symfony/var-dumper:^6.2 \
  symfony/yaml:^6.2

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1117

  1. Benni Mack uploaded patch set 1 12/01/22, 10:20

  2. Georg Ringer updated the commit message in patch set 2 12/01/22, 10:23

  3. Benni Mack updated the commit message in patch set 3 12/01/22, 10:23

  4. core-ci voted on patch set 1 V -1 12/01/22, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34466

  5. core-ci voted on patch set 2 V -1 12/01/22, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34467

  6. core-ci voted on patch set 3 V -1 12/01/22, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34468

  7. Oliver Klee commented on patch set 3 12/01/22, 10:45

    This change fixes 2 of the 4 PHPStan warnings an does not depend on the Symfony raise: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76872
    This line should probably read "6.1", not "6.2".
  8. Stefan Bürk uploaded patch set 4 V -1 12/01/22, 12:55

  9. Stefan Bürk commented on patch set 4 12/01/22, 12:56

    Reply

    Done
  10. core-ci voted on patch set 4 V +1 12/01/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34493

  11. Stefan Bürk updated the commit message in patch set 5 V +1 12/01/22, 13:16

  12. core-ci voted on patch set 5 V -1 12/01/22, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34497

  13. core-ci voted on patch set 5 V +1 12/01/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34497

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 12/01/22, 14:47

  15. Oliver Klee voted on patch set 5 V +1 CR +1 12/01/22, 14:59

  16. Benni Mack voted on patch set 5 V +2 CR +2 12/01/22, 16:01

  17. Benni Mack merged patch set 6 12/01/22, 16:01