Review main Merged

76875[TASK] Streamline Locale + LanguageService initialization calls

Benni Mack CR +2 V +2 Normal +55 −100 updated 12/09/22, 11:29

Commit message

This change optimizes the calls to LanguageService,
adding some types to internal / protected methods,
while also streamlining usages where dependencies
were collected in order to further optimize language keys
and their dependencies.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 914

  1. Benni Mack uploaded patch set 1 12/01/22, 11:33

  2. core-ci voted on patch set 1 V -1 12/01/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34474

  3. Benni Mack uploaded patch set 2 V -1 12/01/22, 21:14

  4. core-ci voted on patch set 2 V -1 12/01/22, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34525

  5. Benni Mack uploaded patch set 3 V -1 12/01/22, 22:19

  6. core-ci voted on patch set 3 V +1 12/01/22, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34528

  7. Benni Mack updated the commit message in patch set 4 V +1 12/01/22, 22:51

  8. core-ci voted on patch set 4 V +1 12/01/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34529

  9. Benni Mack uploaded patch set 5 V +1 12/03/22, 20:57

  10. core-ci voted on patch set 5 V +1 12/03/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34593

  11. Georg Ringer voted on patch set 5 V +1 CR +1 12/09/22, 06:08

  12. Andreas Kienast voted on patch set 5 V +1 CR +1 12/09/22, 11:29

  13. Benni Mack voted on patch set 5 V +2 CR +2 12/09/22, 11:29

  14. Benni Mack merged patch set 6 12/09/22, 11:29