Review main Merged

76882[TASK] Unify position for docheader buttons

Annett Jähnichen CR +2 V +2 Easy +4 −4 updated 12/03/22, 20:37

Commit message

Buttons in button groups either had space between them or were glued
together, because they used to be in the default button group.

The buttons are now separated into different button groups to unify
their positioning.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Annett Jähnichen uploaded patch set 1 12/02/22, 10:08

  2. core-ci voted on patch set 1 V -1 12/02/22, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34548

  3. Annett Jähnichen uploaded patch set 2 V -1 12/02/22, 10:18

  4. Andreas Kienast updated the commit message in patch set 3 12/02/22, 10:25

  5. core-ci voted on patch set 2 V +1 12/02/22, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34549

  6. core-ci voted on patch set 3 V +1 12/02/22, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34552

  7. Lina Wolf commented on patch set 3 V +1 CR +1 12/02/22, 12:16

    Code and result look good to me, tested in the modules backend users and Access, ist that correct?
  8. Lina Wolf rebased onto patch set 4 CR +1 V +1 12/02/22, 12:19

  9. core-ci voted on patch set 4 V +1 12/02/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34564

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 12/02/22, 13:52

  11. Benni Mack voted on patch set 4 CR +1 12/02/22, 20:52

  12. Benni Mack voted on patch set 4 V +1 12/03/22, 19:34

  13. Annett Jähnichen voted on patch set 4 V +2 CR +2 12/03/22, 20:37

  14. Annett Jähnichen merged patch set 5 12/03/22, 20:37