Review main Merged

76891[FEATURE] Introduce TCA type "uuid"

Oli Bartsch CR +2 V +2 Hard +760 −165 updated 03/16/23, 09:59

Commit message

A new TCA type "uuid" is introduced, which
allows to simplify the configuration when
working with fields, containing a UUID.

The functionality is based on the Uid
symfony component.

FormEngine will automatically create a UUID when
non is defined yet. Same does the DataHandler in
case an invalid UUID is defined, while the field
is defined as "required", which is the default.

The UUID is displayed as a readonly input field.

Using the new TCA type, corresponding database
columns are added automatically.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 2336

Show 611 earlier messages
  1. Oli Bartsch uploaded patch set 1 12/02/22, 21:06

  2. core-ci voted on patch set 1 V -1 12/02/22, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34578

  3. Oli Bartsch uploaded patch set 2 V -1 12/22/22, 11:46

  4. core-ci voted on patch set 2 V -1 12/22/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35297

  5. Frank Nägler uploaded patch set 3 V -1 03/13/23, 11:47

  6. core-ci voted on patch set 3 V -1 03/13/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38876

  7. Frank Nägler uploaded patch set 4 V -1 03/15/23, 09:31

  8. Frank Nägler uploaded patch set 5 03/15/23, 09:49

  9. core-ci voted on patch set 4 V -1 03/15/23, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38965

  10. core-ci voted on patch set 5 V +1 03/15/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38967

  11. Oli Bartsch uploaded patch set 6 V +1 03/15/23, 13:02

  1. core-ci voted on patch set 6 V +1 03/15/23, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38981

  2. Oli Bartsch uploaded patch set 7 V +1 03/15/23, 15:17

  3. core-ci voted on patch set 7 V +1 03/15/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38991

  4. Frank Nägler uploaded patch set 8 V +1 03/15/23, 16:08

  5. core-ci voted on patch set 8 V +1 03/15/23, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38993

  6. Oli Bartsch uploaded patch set 9 V +1 03/15/23, 21:43

  7. core-ci voted on patch set 9 V +1 03/15/23, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39022

  8. Oli Bartsch uploaded patch set 10 V +1 03/15/23, 22:21

  9. Oli Bartsch updated the commit message in patch set 11 03/15/23, 22:23

  10. core-ci voted on patch set 11 V +1 03/15/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39025

  11. Benni Mack voted on patch set 11 CR +1 03/15/23, 22:34

  12. core-ci voted on patch set 10 V +1 03/15/23, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39024

  13. Markus Klein updated the commit message in patch set 12 CR +1 V +1 03/16/23, 01:05

  14. Markus Klein commented on patch set 12 03/16/23, 01:13

    Maybe I missed it while reading the code, but how do we deal with translations? IMO any translated record should have its own UUID. Having duplicate UUIDs somehow defeats their purpose, right? We have that in a custom extension, where we actually derive (non-standard) UUIDs for translations by appending the locale to the default language's UUID.

    DatabaseRecordList.php:3150

    why mixed?

    DefaultTcaSchema.php:525

    uuid

    Feature-100171-IntroduceTCATypeUuid.rst:32

    system's

    composer.json:22

    Nope, keep the 12.3 please
  15. Markus Klein voted on patch set 12 CR -1 03/16/23, 01:14

  16. core-ci voted on patch set 12 V +1 03/16/23, 01:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39029

  17. Oli Bartsch uploaded patch set 13 CR -1 V +1 03/16/23, 09:17

  18. Oli Bartsch commented on patch set 13 03/16/23, 09:20

    Reply

    Each translation gets their own uuid. I therefore also removed the "allowLanguageSynchronization" option from the RST as this is not valid for the type.

    DatabaseRecordList.php:3150 Reply

    Done

    DefaultTcaSchema.php:525 Reply

    Done

    Feature-100171-IntroduceTCATypeUuid.rst:32 Reply

    Done

    composer.json:22 Reply

    Done
  19. core-ci voted on patch set 13 V +1 03/16/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39045

  20. Markus Klein voted on patch set 13 CR +1 03/16/23, 09:32

  21. Benni Mack voted on patch set 13 CR +1 03/16/23, 09:38

  22. Frank Nägler voted on patch set 13 V +1 CR +1 03/16/23, 09:41

  23. Benni Mack voted on patch set 13 V +1 03/16/23, 09:44

  24. Oli Bartsch voted on patch set 13 V +2 CR +2 03/16/23, 09:59

  25. Oli Bartsch merged patch set 14 03/16/23, 09:59