76891[FEATURE] Introduce TCA type "uuid"
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Frank Nägler +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Frank Nägler +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 26
- typo3/sysext/backend/Classes/Form/Element/UuidElement.phpnew+119 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaUuid.phpnew+49 −0
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php2+21 −22
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_copytoclipboard.xlf+3 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/UuidElementTest.phpnew+164 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaUuidTest.phpnew+226 −0
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php2+19 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+28 −0
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+11 −1
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100171-IntroduceTCATypeUuid.rst2new+65 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+44 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+2 −0
Show 6 more files
- typo3/sysext/reactions/Classes/Form/Element/UuidElement.phpdeleted+0 −80
- typo3/sysext/reactions/Classes/Hooks/DataHandlerHook.phpdeleted+0 −47
- typo3/sysext/reactions/Configuration/TCA/sys_reaction.php+1 −2
- typo3/sysext/reactions/composer.json2+0 −1
- typo3/sysext/reactions/ext_localconf.php+0 −11
- typo3/sysext/reactions/ext_tables.sql+0 −1
Review log 2336
Show 611 earlier messages
-
Oli Bartsch uploaded patch set 1 12/02/22, 21:06
-
core-ci voted on patch set 1 V -1 12/02/22, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34578
-
Oli Bartsch uploaded patch set 2
V -112/22/22, 11:46 -
core-ci voted on patch set 2 V -1 12/22/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35297
-
Frank Nägler uploaded patch set 3
V -103/13/23, 11:47 -
core-ci voted on patch set 3 V -1 03/13/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38876
-
Frank Nägler uploaded patch set 4
V -103/15/23, 09:31 -
Frank Nägler uploaded patch set 5 03/15/23, 09:49
-
core-ci voted on patch set 4 V -1 03/15/23, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38965
-
core-ci voted on patch set 5 V +1 03/15/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38967
-
Oli Bartsch uploaded patch set 6
V +103/15/23, 13:02
-
core-ci voted on patch set 6 V +1 03/15/23, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38981
-
Oli Bartsch uploaded patch set 7
V +103/15/23, 15:17 -
core-ci voted on patch set 7 V +1 03/15/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38991
-
Frank Nägler uploaded patch set 8
V +103/15/23, 16:08 -
core-ci voted on patch set 8 V +1 03/15/23, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38993
-
Oli Bartsch uploaded patch set 9
V +103/15/23, 21:43 -
core-ci voted on patch set 9 V +1 03/15/23, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39022
-
Oli Bartsch uploaded patch set 10
V +103/15/23, 22:21 -
Oli Bartsch updated the commit message in patch set 11 03/15/23, 22:23
-
core-ci voted on patch set 11 V +1 03/15/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39025
-
Benni Mack voted on patch set 11 CR +1 03/15/23, 22:34
-
core-ci voted on patch set 10 V +1 03/15/23, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39024
-
Markus Klein updated the commit message in patch set 12
CR +1V +103/16/23, 01:05 -
Markus Klein commented on patch set 12 03/16/23, 01:13
Maybe I missed it while reading the code, but how do we deal with translations? IMO any translated record should have its own UUID. Having duplicate UUIDs somehow defeats their purpose, right? We have that in a custom extension, where we actually derive (non-standard) UUIDs for translations by appending the locale to the default language's UUID.DatabaseRecordList.php:3150why mixed?DefaultTcaSchema.php:525uuidFeature-100171-IntroduceTCATypeUuid.rst:32system'scomposer.json:22Nope, keep the 12.3 please -
Markus Klein voted on patch set 12 CR -1 03/16/23, 01:14
-
core-ci voted on patch set 12 V +1 03/16/23, 01:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39029
-
Oli Bartsch uploaded patch set 13
CR -1V +103/16/23, 09:17 -
Oli Bartsch commented on patch set 13 03/16/23, 09:20
Reply
Each translation gets their own uuid. I therefore also removed the "allowLanguageSynchronization" option from the RST as this is not valid for the type.DatabaseRecordList.php:3150ReplyDoneDefaultTcaSchema.php:525ReplyDoneFeature-100171-IntroduceTCATypeUuid.rst:32ReplyDonecomposer.json:22ReplyDone -
core-ci voted on patch set 13 V +1 03/16/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39045
-
Markus Klein voted on patch set 13 CR +1 03/16/23, 09:32
-
Benni Mack voted on patch set 13 CR +1 03/16/23, 09:38
-
Frank Nägler voted on patch set 13 V +1 CR +1 03/16/23, 09:41
-
Benni Mack voted on patch set 13 V +1 03/16/23, 09:44
-
Oli Bartsch voted on patch set 13 V +2 CR +2 03/16/23, 09:59
-
Oli Bartsch merged patch set 14 03/16/23, 09:59