Review main Merged

76925[BUGFIX] Minor fixes in EXT:reactions

Benjamin Kott CR +2 V +2 Normal +117 −104 updated 12/05/22, 16:28

Commit message

- Use TYPO3.Icons
- Make reactionTypes accessible to fluid
- Allow type sorting and use correct field
- Add contextmenu and icon to backend view

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 910

  1. Benjamin Kott uploaded patch set 1 12/05/22, 15:36

  2. core-ci voted on patch set 1 V +1 12/05/22, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34642

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/05/22, 15:49

  4. Stefan Froemken commented on patch set 1 V -1 12/05/22, 15:53

    If I use the Context-Menu and click on History/Undo it results in a PHP Warning: PHP Warning: Array to string conversion in /var/www/html/TYPO3.CMS/typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php line 351
  5. Andreas Kienast commented on patch set 1 12/05/22, 15:54

    Reply

    This looks like another issue that is not related to this patch.
  6. Frank Nägler voted on patch set 1 V +1 CR +1 12/05/22, 16:05

  7. Andreas Kienast voted on patch set 1 V +1 CR +1 12/05/22, 16:05

  8. Stefan Froemken commented on patch set 1 V 0 12/05/22, 16:07

    I have remove the -1 and created a new issue: https://forge.typo3.org/issues/99277
  9. Benni Mack voted on patch set 1 V +2 CR +2 12/05/22, 16:28

  10. Benni Mack merged patch set 2 12/05/22, 16:28