76925[BUGFIX] Minor fixes in EXT:reactions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Gruntfile.js+4 −0
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+1 −1
- typo3/sysext/reactions/Classes/Reaction/CreateRecordReaction.php+1 −1
- typo3/sysext/reactions/Classes/Repository/ReactionDemand.php+1 −1
- typo3/sysext/reactions/Configuration/TCA/sys_reaction.php+1 −1
- typo3/sysext/reactions/Configuration/Icons.php+0 −4
- typo3/sysext/reactions/Resources/Private/Language/locallang_db.xlf+89 −89
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+19 −5
- typo3/sysext/reactions/Resources/Public/Icons/Extension.svg+1 −1
- typo3/sysext/reactions/Resources/Public/Icons/mimetypes-x-sys_reaction.svgdeleted+0 −1
Review log 910
-
Benjamin Kott uploaded patch set 1 12/05/22, 15:36
-
core-ci voted on patch set 1 V +1 12/05/22, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34642
-
Benni Mack voted on patch set 1 V +1 CR +1 12/05/22, 15:49
-
Stefan Froemken commented on patch set 1 V -1 12/05/22, 15:53
If I use the Context-Menu and click on History/Undo it results in a PHP Warning: PHP Warning: Array to string conversion in /var/www/html/TYPO3.CMS/typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php line 351 -
Andreas Kienast commented on patch set 1 12/05/22, 15:54
Reply
This looks like another issue that is not related to this patch. -
Frank Nägler voted on patch set 1 V +1 CR +1 12/05/22, 16:05
-
Andreas Kienast voted on patch set 1 V +1 CR +1 12/05/22, 16:05
-
Stefan Froemken commented on patch set 1 V 0 12/05/22, 16:07
I have remove the -1 and created a new issue: https://forge.typo3.org/issues/99277 -
Benni Mack voted on patch set 1 V +2 CR +2 12/05/22, 16:28
-
Benni Mack merged patch set 2 12/05/22, 16:28