Review main Merged

76926[BUGFIX] Avoid invalid cache identifier in SchemaInformation

Andreas Kienast CR +2 V +2 Easy +5 −1 updated 12/10/22, 14:07

Commit message

The database may contain special characters (e.g. dots) that are
considered invalid by the caching framework, potentially breaking
the whole TYPO3 installation.

Special chars in the database name are now replaced.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1925

  1. Andreas Kienast uploaded patch set 1 12/05/22, 15:39

  2. Stefan Bürk voted on patch set 1 CR -1 12/05/22, 15:46

  3. Stefan Bürk commented on patch set 1 12/05/22, 15:46

    will take care later
  4. core-ci voted on patch set 1 V +1 12/05/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34643

  5. Andreas Kienast uploaded patch set 2 CR -1 V +1 12/05/22, 15:58

  6. core-ci voted on patch set 2 V +1 12/05/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34644

  7. Oliver Klee voted on patch set 2 CR +1 12/05/22, 16:11

  8. Stefan Bürk uploaded patch set 3 CR +1 V +1 12/06/22, 21:04

  9. core-ci voted on patch set 3 V -1 12/06/22, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34739

  10. Stefan Bürk uploaded patch set 4 V -1 12/06/22, 21:13

  11. core-ci voted on patch set 4 V +1 12/06/22, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34740

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 12/07/22, 17:51

  13. Anja Leichsenring commented on patch set 4 CR -1 12/07/22, 19:29

    SchemaInformation.php:86

    why do you use a class instance here, but keep the local one at the next code line?
  14. Stefan Bürk uploaded patch set 5 CR +1 V +1 12/08/22, 08:48

  15. Stefan Bürk commented on patch set 5 12/08/22, 08:52

    SchemaInformation.php:86 Reply

    my bad. thanks for pointing out. done
  16. core-ci voted on patch set 5 V +1 12/08/22, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34786

  17. Stefan Bürk updated the commit message in patch set 6 V +1 12/08/22, 09:10

  18. core-ci voted on patch set 6 V +1 12/08/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34787

  19. Andreas Kienast commented on patch set 6 CR -1 12/08/22, 09:19

    Will test asap
  20. Andreas Kienast voted on patch set 6 V +1 CR +1 12/09/22, 13:37

  21. Stefan Bürk voted on patch set 6 V +1 CR +1 12/10/22, 10:23

  22. Christian Kuhn voted on patch set 6 V +1 CR +1 12/10/22, 11:16

  23. Oliver Klee voted on patch set 6 CR +1 12/10/22, 11:17

  24. Stefan Bürk voted on patch set 6 V +2 CR +2 12/10/22, 14:07

  25. Stefan Bürk merged patch set 7 12/10/22, 14:07