Review main Merged

76927[BUGFIX] Ensure inserted json data is properly checked in DataHandler

Stefan Bürk CR +2 V +2 Easy +9 −0 updated 12/05/22, 22:35

Commit message

Native JSON field support along with a custom TCA user dbType
`json` has been added as new features. This has been used to
provide a more dynamic configuration in `ext:reactions` for
the field variable config.

Backend uses DataHandler to persist the data to the database,
and checks if the retrieved value matches the to-persist value.

At least MySQL seems to save provided array data by sorting it
by key, thus the check before-after does not match, because of
different key orderings. As it may be hard to ensure that
beforehand, this change sorts the persisted and the provided
array recursivly before comparing them. This ensures that at
least the "same" data is written to the database.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk uploaded patch set 1 12/05/22, 21:09

  2. Stefan Bürk updated the commit message in patch set 2 12/05/22, 21:12

  3. Frank Nägler voted on patch set 2 V +1 CR +1 12/05/22, 21:16

  4. core-ci voted on patch set 1 V +1 12/05/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34648

  5. core-ci voted on patch set 2 V +1 12/05/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34649

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/05/22, 22:35

  7. Benni Mack merged patch set 3 12/05/22, 22:35