Review main Abandoned

76932[BUGFIX] Do not pass a possible boolean value into string function

Daniel Siepmann CR 0 V 0 Easy +2 −1 updated 12/06/22, 07:33

Commit message

This prevents PHP TypeError due to passing an invalid type to the
function.
`false` is an expected valid value which needs to be respected by the
source code.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Daniel Siepmann uploaded patch set 1 12/06/22, 07:06

  2. core-ci voted on patch set 1 V +1 12/06/22, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34692

  3. Daniel Siepmann abandoned the change 12/06/22, 07:33

    Wrong assumptions, the value should always be a string