76937[FEATURE] Add Fluid TrimViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Chris Müller +1
-
Verified V +2 Done
- Benni Mack +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99285-AddFluidTrimViewhelper.rst2new+72 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/TrimViewHelper.php5new+134 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/TrimViewHelperTest.phpnew+123 −0
- typo3/sysext/tstemplate/Classes/ViewHelpers/TrimViewHelper.phpdeleted+0 −37
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTree.html4+2 −2
Review log 2331
Show 46 earlier messages
-
Benjamin Kott uploaded patch set 1 12/06/22, 10:12
-
core-ci voted on patch set 1 V -1 12/06/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34702
-
Benjamin Kott uploaded patch set 2
V -112/06/22, 10:31 -
core-ci voted on patch set 2 V -1 12/06/22, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34703
-
Benni Mack uploaded patch set 3
V -112/06/22, 10:43 -
Benjamin Kott commented on patch set 3 CR -1 12/06/22, 10:49
ObjectBrowserTree.html:79should be <f:format.trim>
-
Benjamin Kott uploaded patch set 4
CR -112/06/22, 10:57 -
Benjamin Kott commented on patch set 4 12/06/22, 10:58
ObjectBrowserTree.html:56ReplyDoneObjectBrowserTree.html:79ReplyDone -
core-ci voted on patch set 3 V -1 12/06/22, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34704
-
core-ci voted on patch set 4 V -1 12/06/22, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34714
-
Benjamin Kott uploaded patch set 5
V -112/06/22, 11:25 -
core-ci voted on patch set 5 V -1 12/06/22, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34717
-
Oliver Klee commented on patch set 5 12/06/22, 12:09
TrimViewHelper.php:83Is the normal space missing here? -
Benjamin Kott commented on patch set 5 12/06/22, 13:56
TrimViewHelper.php:83Replythere is a space in front of \t -
Oliver Klee commented on patch set 5 12/06/22, 14:09
TrimViewHelper.php:83ReplyAck -
Chris Müller commented on patch set 5 CR -1 12/06/22, 16:58
Please add examples in the docblock of the class and also in the rst. Background: The docblocks are used to render the documentation of the view helpers automatically. Example: - https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php - https://docs.typo3.org/other/typo3/view-helper-reference/11.5/en-us/typo3/fluid/latest/Format/Crop.html -
Benjamin Kott uploaded patch set 6
CR -1V -112/08/22, 09:30 -
Benjamin Kott commented on patch set 6 12/08/22, 09:32
Reply
done -
core-ci voted on patch set 6 V -1 12/08/22, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34788
-
Benjamin Kott uploaded patch set 7
V -112/08/22, 09:41 -
core-ci voted on patch set 7 V +1 12/08/22, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34789
-
Simon Schaufelberger commented on patch set 7 12/08/22, 11:08
why is this not part of the external fluid package? is there any reason why this must be part of the core? -
Christian Kuhn commented on patch set 7 12/08/22, 11:13
generally fine with me. could potentially transferred to fluid standalone later, too.Feature-99285-AddFluidTrimViewhelper.rst:26maybe add a simple usage example? just one, the rest is in the header and rendered as .rst ...TrimViewHelper.php:79the constants can and should be made private, i'd say. -
Christian Kuhn commented on patch set 7 12/08/22, 11:13
Reply
we can add it to core for now and maybe later transfer to fluid standalone. would be fine with me. -
Chris Müller uploaded patch set 8
V +112/11/22, 07:11 -
Chris Müller commented on patch set 8 12/11/22, 07:14
The double backticks are not resolved by Sphinx when the string in it starts or ends with a space, so I am using a code block for displaying the result. Additionally, I added the "#" character before and after each usage of the view helper, so the spaces are better visible.Feature-99285-AddFluidTrimViewhelper.rst:26ReplyDoneTrimViewHelper.php:79ReplyDone -
core-ci voted on patch set 8 V +1 12/11/22, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34873
-
Chris Müller voted on patch set 8 V +1 CR +1 12/11/22, 07:30
-
Oliver Klee wrote 12/11/22, 11:03
Removed cc Oliver Klee. -
Benni Mack voted on patch set 8 V +2 CR +2 12/12/22, 09:51
-
Benni Mack merged patch set 9 12/12/22, 09:51
ObjectBrowserTree.html:56