Review main Merged

76942[BUGFIX] Fix addService PHP 8 warning

Benni Mack CR +2 V +2 Easy +21 −1 updated 12/07/22, 14:13

Commit message

If a service is registered with ExtensionManagementUtility::addService(),
that does not have a "os" flag, then a PHP 8 warning
is raised (during loading).

This change avoids this warning.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 12/06/22, 19:44

  2. core-ci voted on patch set 1 V +1 12/06/22, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34735

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 12/06/22, 20:31

  4. Oliver Klee voted on patch set 1 CR +1 12/06/22, 20:35

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 12/07/22, 14:00

  6. Nikita Hovratov voted on patch set 1 V +2 CR +2 12/07/22, 14:13

  7. Nikita Hovratov merged patch set 2 12/07/22, 14:13