Review main Merged

76951[TASK] Allow custom tables in create record reaction

Oli Bartsch CR +2 V +2 Hard +219 −45 updated 12/14/22, 12:03

Commit message

Extension authors can now add tables to the create record
reaction via ExtensionManagementUtility::addTcaSelectItem().

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 2839

Show 1014 earlier messages
  1. Oli Bartsch uploaded patch set 1 12/07/22, 16:23

  2. core-ci voted on patch set 1 V -1 12/07/22, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34766

  3. Oli Bartsch uploaded patch set 2 V -1 12/07/22, 20:53

  4. Oli Bartsch updated the commit message in patch set 3 12/07/22, 20:55

  5. core-ci voted on patch set 2 V +1 12/07/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34774

  6. core-ci voted on patch set 3 V +1 12/07/22, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34775

  7. Georg Ringer commented on patch set 3 12/09/22, 06:05

    what about moving this setting into security?
  8. Oli Bartsch commented on patch set 3 12/09/22, 07:44

    Reply

    Currently on reworking this patch after feedback from Benni.
  9. Oli Bartsch uploaded patch set 4 V +1 12/09/22, 08:40

  10. core-ci voted on patch set 4 V +1 12/09/22, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34826

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 12/09/22, 11:32

  12. Christian Kuhn commented on patch set 4 CR -1 12/10/22, 15:15

    sys_reaction.php:3

    why is this in ext:core? Moving the calls to ext:reaction (or hard-coding it as defaults directly) will skip the override. also ext:core should not have such a direct forward dependency to ext:reactions. I'm fine with having the calls in ext:frontend and ext:sys_note, since these require ext:core anyways, but with ext:core that should not have dependencies to other extensions, and is required by ext:reactions anyways, I think it would be better to hardcode the three tables to ext:reactions as defaults instead.
  13. Oli Bartsch uploaded patch set 5 CR +1 V +1 12/12/22, 07:42

  14. Oli Bartsch commented on patch set 5 12/12/22, 07:42

    sys_reaction.php:3 Reply

    Thanks for your feedback. Changed it accordingly.
  1. Andreas Kienast voted on patch set 5 V +1 CR +1 12/12/22, 07:43

  2. core-ci voted on patch set 5 V +1 12/12/22, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34900

  3. Christian Kuhn voted on patch set 5 CR +1 12/12/22, 11:39

  4. Oli Bartsch uploaded patch set 6 CR +1 V +1 12/12/22, 20:35

  5. core-ci voted on patch set 6 V -1 12/12/22, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34954

  6. Oli Bartsch uploaded patch set 7 V -1 12/12/22, 21:15

  7. core-ci voted on patch set 7 V +1 12/12/22, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34959

  8. Andreas Kienast voted on patch set 7 V +1 CR +1 12/13/22, 12:00

  9. Benni Mack commented on patch set 7 12/14/22, 08:49

    ReactionItemsProcFunc.php:36

    can't we put the Utility class code in this class?
  10. Oli Bartsch commented on patch set 7 12/14/22, 08:55

    ReactionItemsProcFunc.php:36 Reply

    The method is used at two different places and might be used at more in the future. It does not only relate to the ItemsProcFunc. Therefore, I'd like to keep it in the Utility class, which will surely be enhanced in the future.
  11. Benni Mack commented on patch set 7 12/14/22, 10:09

    ReactionItemsProcFunc.php:36 Reply

    but should we mark it as "internal" for the time being?
  12. Oli Bartsch commented on patch set 7 12/14/22, 10:14

    ReactionItemsProcFunc.php:36 Reply

    Yes, it's already marked as internal
  13. Daniel Goerz uploaded patch set 8 CR +1 V +1 12/14/22, 10:20

  14. core-ci voted on patch set 8 V -1 12/14/22, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35089

  15. Daniel Goerz uploaded patch set 9 V -1 12/14/22, 10:32

  16. core-ci voted on patch set 9 V +1 12/14/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35090

  17. Oli Bartsch uploaded patch set 10 V +1 12/14/22, 11:15

  18. Oli Bartsch uploaded patch set 11 12/14/22, 11:17

  19. Benni Mack voted on patch set 11 CR +1 12/14/22, 11:25

  20. core-ci voted on patch set 11 V +1 12/14/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35093

  21. core-ci voted on patch set 10 V +1 12/14/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35092

  22. Daniel Goerz voted on patch set 11 V +1 CR +1 12/14/22, 11:43

  23. Andreas Kienast voted on patch set 11 V +1 CR +1 12/14/22, 12:02

  24. Oli Bartsch voted on patch set 11 V +2 CR +2 12/14/22, 12:03

  25. Oli Bartsch merged patch set 12 12/14/22, 12:03