76974[TASK] Align error responses in ReactionResolver
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 2229
Show 4 earlier messages
-
Oliver Klee wrote 12/07/22, 21:28
Removed reviewer Oliver Klee. -
core-ci voted on patch set 2 V +1 12/07/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34778
-
core-ci voted on patch set 1 V +1 12/07/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34777
-
Oli Bartsch uploaded patch set 3
V +112/08/22, 22:28 -
core-ci voted on patch set 3 V +1 12/08/22, 22:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34818
-
Andreas Kienast voted on patch set 3 CR +1 12/09/22, 12:36
-
Christian Kuhn commented on patch set 3 12/10/22, 15:27
Related: #98373 -
Oli Bartsch uploaded patch set 4
CR +1V +112/12/22, 07:51 -
Andreas Kienast voted on patch set 4 CR +1 12/12/22, 07:52
-
Oli Bartsch updated the commit message in patch set 5
CR +112/12/22, 07:53 -
Oli Bartsch commented on patch set 5 12/12/22, 07:53
Reply
Done -
Andreas Kienast voted on patch set 5 CR +1 12/12/22, 07:53
-
core-ci voted on patch set 4 V +1 12/12/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34901
-
core-ci voted on patch set 5 V +1 12/12/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34902
-
Benni Mack voted on patch set 5 V +1 CR +1 12/12/22, 08:07
-
Daniel Goerz commented on patch set 5 12/12/22, 09:14
ReactionResolver.php:74No secret or invalid secret should get be a 401 Unauthorized response IMOReactionResolver.php:86Isn't this still a server side error? -
Oli Bartsch uploaded patch set 6
CR +1V +112/12/22, 09:19 -
Oli Bartsch uploaded patch set 7 12/12/22, 09:25
-
Oli Bartsch commented on patch set 7 12/12/22, 09:27
ReactionResolver.php:74ReplyDoneReactionResolver.php:86ReplyNo, this exception is only thrown at this place in case a ReactionInstruction with an unknown reaction type is resolved. This means actually still a client error but as for the invalid identifier, this should be a 404 response. Changed it as discussed. -
Andreas Kienast voted on patch set 7 V +1 CR +1 12/12/22, 09:30
-
core-ci voted on patch set 7 V +1 12/12/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34905
-
core-ci voted on patch set 6 V +1 12/12/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34904
-
Benni Mack voted on patch set 7 V +1 CR +1 12/12/22, 09:48
-
Oli Bartsch voted on patch set 7 V +2 CR +2 12/12/22, 09:56
-
Oli Bartsch merged patch set 8 12/12/22, 09:56