Review main Merged

76975[BUGFIX] Respect ReactionDemand for shortcuts

Oli Bartsch CR +2 V +2 Easy +8 −4 updated 12/10/22, 15:04

Commit message

Especially for detailed filters, the shortcut button
does now respect the current demand.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 12/07/22, 21:36

  2. Oli Bartsch updated the commit message in patch set 2 12/07/22, 21:36

  3. core-ci voted on patch set 1 V +1 12/07/22, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34779

  4. core-ci voted on patch set 2 V +1 12/07/22, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34780

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 12/09/22, 12:07

  6. Andreas Kienast commented on patch set 2 12/09/22, 12:09

    ManagementController.php:103

    Would it make sense to have $demand->toArray() that takes care of crafting this array?
  7. Oli Bartsch commented on patch set 2 12/09/22, 12:37

    ManagementController.php:103 Reply

    I would expect a "toArray()" method to return the objects properties as array. However in this case only relevant properties are added and additionally the demand properties "name" and "reaction_type" are already bundled into "getParameters()". So for now, I would like to leave it this way, if this is fine with you.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 12/10/22, 14:46

  9. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 12/10/22, 14:47

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 12/10/22, 14:50

  11. core-ci voted on patch set 3 V +1 12/10/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34855

  12. Stefan Bürk voted on patch set 3 V +2 CR +2 12/10/22, 15:04

  13. Stefan Bürk merged patch set 4 12/10/22, 15:04