76975[BUGFIX] Respect ReactionDemand for shortcuts
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1013
-
Oli Bartsch uploaded patch set 1 12/07/22, 21:36
-
Oli Bartsch updated the commit message in patch set 2 12/07/22, 21:36
-
core-ci voted on patch set 1 V +1 12/07/22, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34779
-
core-ci voted on patch set 2 V +1 12/07/22, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34780
-
Andreas Kienast voted on patch set 2 V +1 CR +1 12/09/22, 12:07
-
Andreas Kienast commented on patch set 2 12/09/22, 12:09
-
Oli Bartsch commented on patch set 2 12/09/22, 12:37
ManagementController.php:103ReplyI would expect a "toArray()" method to return the objects properties as array. However in this case only relevant properties are added and additionally the demand properties "name" and "reaction_type" are already bundled into "getParameters()". So for now, I would like to leave it this way, if this is fine with you. -
Christian Kuhn voted on patch set 2 V +1 CR +1 12/10/22, 14:46
-
Stefan Bürk updated the commit message in patch set 3
CR +1V +112/10/22, 14:47 -
Christian Kuhn voted on patch set 3 V +1 CR +1 12/10/22, 14:50
-
core-ci voted on patch set 3 V +1 12/10/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34855
-
Stefan Bürk voted on patch set 3 V +2 CR +2 12/10/22, 15:04
-
Stefan Bürk merged patch set 4 12/10/22, 15:04
ManagementController.php:103