Review main Merged

76993[BUGFIX] Correctly turn nodes into TypoScript references

Christian Kuhn CR +2 V +2 Normal +89 −3 updated 12/08/22, 15:35

Commit message

Given TypoScript:
    foo = foo
    foo.childfoo = childfoo
    source = source
    foo =< source

Current AST builder output:
    foo = foo
    foo.childfoo = chilfoo
    source = source

Expected AST builder output:
    foo =< source
    foo.childfoo = childfoo
    source = source

The current TypoScript AST builder fails here since
it does not turn the existing "foo" ChildNode into
a ReferenceChildNode.

The patch adds test coverage and fixes the issue.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Achim Fritz +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/08/22, 12:56

  2. core-ci voted on patch set 1 V +1 12/08/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34793

  3. Achim Fritz voted on patch set 1 V +1 CR +1 12/08/22, 13:51

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 12/08/22, 15:34

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/08/22, 15:35

  6. Christian Kuhn merged patch set 2 12/08/22, 15:35