Review main Merged

76994[FEATURE] Add PSR-14 Event for fetching YouTube/Vimeo preview image

Kees Sonnema CR +2 V +2 Hard +295 −20 updated 01/31/23, 16:16

Commit message

A new event is added to modify
the preview image for online media
providers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Robert van Kammen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 3651

Show 1826 earlier messages
  1. Kees Sonnema uploaded patch set 1 12/08/22, 14:15

  2. core-ci voted on patch set 1 V -1 12/08/22, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34799

  3. Kees Sonnema uploaded patch set 2 V -1 12/08/22, 14:28

  4. Kees Sonnema uploaded patch set 3 12/08/22, 14:36

  5. core-ci voted on patch set 2 V -1 12/08/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34800

  6. core-ci voted on patch set 3 V -1 12/08/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34801

  7. Kees Sonnema uploaded patch set 4 V -1 12/08/22, 15:10

  8. core-ci voted on patch set 4 V +1 12/08/22, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34803

  9. Chris Müller commented on patch set 4 12/08/22, 15:29

    VimeoHelper.php:62

    Can we use constructor injection instead of makeInstance?

    YouTubeHelper.php:64

    Can we use constructor injection instead of makeInstance?
  10. Kees Sonnema uploaded patch set 5 V +1 12/08/22, 15:39

  11. Kees Sonnema commented on patch set 5 12/08/22, 15:44

    VimeoHelper.php:62 Reply

    Sadly this is not possible due to the OnlineMediaHelperInterface.

    YouTubeHelper.php:64 Reply

    Sadly this is not possible due to the OnlineMediaHelperInterface.
  12. core-ci voted on patch set 5 V -1 12/08/22, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34804

  13. Kees Sonnema commented on patch set 6 V -1 12/08/22, 15:59

    Published edit on patch set 5.
  14. core-ci voted on patch set 6 V -1 12/08/22, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34805

  15. Chris Müller commented on patch set 6 12/08/22, 16:26

    VideoPreviewEvent.php:25

    A better name for the event might by "ModifyVideoPreviewFileEvent" or "AfterVideoPreviewFetchedEvent". That makes the purpose of the event clearer.

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:5

    The "=" chars must be at least as long as the header. Additionally, the filename is wrong.

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:14

    Please also describe the purpose of the event here.

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:32

    The event is superfluous since v11.

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:44

    Can you give a scenario how to use it than just a comment?
  16. Kees Sonnema uploaded patch set 7 V -1 12/09/22, 13:25

  17. Kees Sonnema commented on patch set 7 12/09/22, 13:31

    VideoPreviewEvent.php:25 Reply

    Done

    VimeoHelper.php:62 Reply

    Done

    YouTubeHelper.php:64 Reply

    Done

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:5 Reply

    Done

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:14 Reply

    Done

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:32 Reply

    Done

    Feature-99118-PSR-14EventToDefineWhetherFilesAreSelectable.rst:44 Reply

    Done
  18. core-ci voted on patch set 7 V +1 12/09/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34833

  19. Rudy Gnodde voted on patch set 7 V +1 CR +1 12/09/22, 13:50

  20. Rudy Gnodde updated the commit message in patch set 8 CR +1 V +1 12/09/22, 13:51

  21. Rudy Gnodde voted on patch set 8 V +1 CR +1 12/09/22, 13:51

  22. core-ci voted on patch set 8 V +1 12/09/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34835

  23. Robert van Kammen voted on patch set 8 V +1 CR +1 12/09/22, 14:03

  24. Joey Bouten voted on patch set 8 CR +1 12/13/22, 13:43

  25. Jörg Bösche voted on patch set 8 CR +1 12/15/22, 15:25

  26. Benni Mack commented on patch set 8 CR -1 12/21/22, 10:12

    I wonder if we could move the Event to the place where the OnlineMedia Helpers are calling "getPreviewImage" this way, other OnlineMedia helpers could also benefit from this change. OK for you if I touch this area?
  1. Rudy Gnodde commented on patch set 8 V 0 CR 0 12/29/22, 07:54

    Reply

    Agreed. We did check if it can be handled in `TYPO3\CMS\Core\Resource\OnlineMedia\Processing\PreviewProcessing`, but couldn't find a clean/easy way of doing it there. Looking at it now I see it's basically doing the same thing twice there. Creating an instance of `OnlineMediaHelperRegistry` and calling `...->getOnlineMediaHelper($...)->getPreviewImage($...)`. Would moving that to a separate (protected) method and handling the Event in there be a solution?
  2. Benni Mack uploaded patch set 9 CR +1 V +1 01/09/23, 08:56

  3. core-ci voted on patch set 9 V -1 01/09/23, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35597

  4. Benni Mack uploaded patch set 10 V -1 01/19/23, 10:32

  5. core-ci voted on patch set 10 V -1 01/19/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36188

  6. Benni Mack uploaded patch set 11 V -1 01/19/23, 11:13

  7. core-ci voted on patch set 11 V -1 01/19/23, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36200

  8. Benni Mack rebased onto patch set 12 V -1 01/19/23, 14:49

  9. core-ci voted on patch set 12 V +1 01/19/23, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36259

  10. Rudy Gnodde commented on patch set 12 V +1 CR +1 01/20/23, 08:52

    Reply

    Looks good. Thanks
  11. Kees Sonnema voted on patch set 12 V +1 CR +1 01/20/23, 08:56

  12. Jörg Bösche voted on patch set 12 CR +1 01/20/23, 09:04

  13. Benni Mack commented on patch set 12 CR -1 01/20/23, 13:05

    The RST is now wrong, we need to adapt it. Anyone up for it?
  14. Benni Mack uploaded patch set 13 CR +1 V +1 01/31/23, 13:33

  15. Benni Mack uploaded patch set 14 01/31/23, 13:34

  16. core-ci voted on patch set 13 V +1 01/31/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36822

  17. core-ci voted on patch set 14 V +1 01/31/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36823

  18. Rudy Gnodde voted on patch set 14 V +1 CR +1 01/31/23, 14:37

  19. Oli Bartsch commented on patch set 14 CR -1 01/31/23, 14:38

    On it
  20. Oli Bartsch uploaded patch set 15 CR +1 V +1 01/31/23, 15:40

  21. Oli Bartsch voted on patch set 15 V +1 CR +1 01/31/23, 15:41

  22. Robert van Kammen voted on patch set 15 CR +1 01/31/23, 15:44

  23. core-ci voted on patch set 15 V +1 01/31/23, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36831

  24. Benni Mack voted on patch set 15 V +2 CR +2 01/31/23, 16:16

  25. Benni Mack merged patch set 16 01/31/23, 16:16