76997[BUGFIX] Properly consider else condition in TypoScript
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/core/Classes/Configuration/Event/ModifyLoadedPageTsConfigEvent.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeAstBuilderVisitor.php+10 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+5 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSetupConditionConstantSubstitutionVisitor.php+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/userTsConfigTestFixture.csv+9 −1
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+23 −0
- typo3/sysext/core/Tests/Functional/TypoScript/UserTsConfigFactoryTest.php+21 −1
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/PageHttpsConditionHelloWorld.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+45 −6
Review log 811
-
Christian Kuhn uploaded patch set 1 12/08/22, 17:18
-
Christian Kuhn uploaded patch set 2 12/08/22, 17:21
-
core-ci voted on patch set 1 V +1 12/08/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34808
-
Christian Kuhn updated the commit message in patch set 3 12/08/22, 17:26
-
core-ci voted on patch set 2 V +1 12/08/22, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34809
-
Stefan Bürk voted on patch set 3 V +1 CR +1 12/08/22, 17:33
-
core-ci voted on patch set 3 V +1 12/08/22, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34810
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 12/08/22, 19:11
-
Markus Klein voted on patch set 3 CR +1 12/08/22, 19:16
-
Christian Kuhn voted on patch set 3 V +2 CR +2 12/09/22, 09:18
-
Christian Kuhn merged patch set 4 12/09/22, 09:18