Review main Merged

76997[BUGFIX] Properly consider else condition in TypoScript

Christian Kuhn CR +2 V +2 Normal +125 −11 updated 12/09/22, 09:18

Commit message

When establishing the TypoScript condition verdict visitors,
the tstemplate related "fake" IncludeTreeConditionEnforcerVisitor
properly handled "[ELSE]" conditions, while the production
IncludeTreeConditionMatcherVisitor missed the negation
toggle, resulting in never matching else conditions.

The patches fixes this and adds functional tests to verify
proper else-condition scenarios in UserTsConfig, PageTsConfig
and Frontend TypoScript rendering.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 811

  1. Christian Kuhn uploaded patch set 1 12/08/22, 17:18

  2. Christian Kuhn uploaded patch set 2 12/08/22, 17:21

  3. core-ci voted on patch set 1 V +1 12/08/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34808

  4. Christian Kuhn updated the commit message in patch set 3 12/08/22, 17:26

  5. core-ci voted on patch set 2 V +1 12/08/22, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34809

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 12/08/22, 17:33

  7. core-ci voted on patch set 3 V +1 12/08/22, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34810

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 12/08/22, 19:11

  9. Markus Klein voted on patch set 3 CR +1 12/08/22, 19:16

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 12/09/22, 09:18

  11. Christian Kuhn merged patch set 4 12/09/22, 09:18