Review main Merged

77000[BUGFIX] Handle reaction records with missing reaction class

Oli Bartsch CR +2 V +2 Normal +107 −70 updated 12/10/22, 15:14

Commit message

When reaction records are present in a system and their
corresponding implementation class is not, the reaction
module failed due to fluid parser errors.

This is now handled properly. A badge with corresponding
information is displayed for such records and functions
like "edit record" are disabled, since they would lead to
further errors.

Additionally, this also fixes the hide / unhide control,
which previously did not work due to usage of a non-
existent magic getter.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Oli Bartsch uploaded patch set 1 12/08/22, 22:24

  2. core-ci voted on patch set 1 V -1 12/08/22, 22:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34817

  3. Oli Bartsch uploaded patch set 2 V -1 12/09/22, 08:51

  4. core-ci voted on patch set 2 V +1 12/09/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34827

  5. Benni Mack voted on patch set 2 CR +1 12/09/22, 11:15

  6. Andreas Kienast voted on patch set 2 CR +1 12/09/22, 12:28

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/10/22, 15:03

  8. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 12/10/22, 15:05

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 12/10/22, 15:05

  10. core-ci voted on patch set 3 V +1 12/10/22, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34856

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 12/10/22, 15:14

  12. Stefan Bürk merged patch set 4 12/10/22, 15:14